From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit v4 10/18] combogrid: add 'showClearTrigger' config
Date: Wed, 28 Feb 2024 11:41:49 +0100 [thread overview]
Message-ID: <2c660e4f-1a2a-43d7-a77c-819ca41c78b7@proxmox.com> (raw)
In-Reply-To: <20240228100106.87262-11-l.wagner@proxmox.com>
Am 28/02/2024 um 11:00 schrieb Lukas Wagner:
> This allows one configure the clear trigger to be shown, even if
> 'allowBlank' is set false. This can be useful if one has a
> non-editable combogrid where the value is set to something not
> present in the store. Example: Match rule editing, one selects
> a backup job to be match. If the backup job is removed and the match
> rule edit window is opened again, then the old, deleted value cannot
> be removed from the combogrid if there is no clear trigger.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
> src/form/ComboGrid.js | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>
applied, thanks!
I made a follow up though to clarify that the showClearTrigger cannot be
used to hide it, and to simplify the boolean expression.
diff --git a/src/form/ComboGrid.js b/src/form/ComboGrid.js
index 3aaa717..cca92b1 100644
--- a/src/form/ComboGrid.js
+++ b/src/form/ComboGrid.js
@@ -32,6 +32,8 @@ Ext.define('Proxmox.form.ComboGrid', {
notFoundIsValid: false,
deleteEmpty: false,
errorHeight: 100,
+ // NOTE: the trigger will always be shown if allowBlank is true, setting showClearTrigger
+ // to false cannot change that
showClearTrigger: false,
},
@@ -55,10 +57,7 @@ Ext.define('Proxmox.form.ComboGrid', {
setValue: function(value) {
let me = this;
let empty = Ext.isArray(value) ? !value.length : !value;
- me.triggers.clear.setVisible(
- (!empty && me.allowBlank) ||
- (!empty && me.showClearTrigger),
- );
+ me.triggers.clear.setVisible(!empty && (me.allowBlank || me.showClearTrigger));
return me.callParent([value]);
},
next prev parent reply other threads:[~2024-02-28 10:41 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 10:00 [pve-devel] [PATCH manager/widget-toolkit/docs v4 00/18] notifications: notification metadata matching improvements Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 01/18] api: notifications: add 'smtp' to target index Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 02/18] api: jobs: vzdump: pass job 'id' parameter Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 03/18] ui: dc: backup: send 'id' property when starting a backup job manually Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 04/18] ui: dc: backup: allow to set custom job id in advanced settings Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 05/18] api: replication: add 'replication-job' to notification metadata Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 06/18] vzdump: apt: notification: do not include domain in 'hostname' field Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 07/18] api: replication: include 'hostname' field for notifications Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 08/18] api: notification: add API for getting known metadata fields/values Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH manager v4 09/18] ui: utils: add overrides for translatable notification fields/values Lukas Wagner
2024-02-28 10:00 ` [pve-devel] [PATCH widget-toolkit v4 10/18] combogrid: add 'showClearTrigger' config Lukas Wagner
2024-02-28 10:41 ` Thomas Lamprecht [this message]
2024-02-28 10:00 ` [pve-devel] [PATCH widget-toolkit v4 11/18] utils: add extendable, translatable notifiction event descriptions Lukas Wagner
2024-02-28 10:42 ` [pve-devel] applied: " Thomas Lamprecht
2024-02-28 10:01 ` [pve-devel] [PATCH widget-toolkit v4 12/18] notification: matcher: match-field: show known fields/values Lukas Wagner
2024-02-28 10:01 ` [pve-devel] [PATCH widget-toolkit v4 13/18] notification: matcher: move match-field formulas to local viewModel Lukas Wagner
2024-02-28 10:01 ` [pve-devel] [PATCH widget-toolkit v4 14/18] notification: matcher: move match-calendar fields to panel Lukas Wagner
2024-02-28 10:01 ` [pve-devel] [PATCH widget-toolkit v4 15/18] notification: matcher: move match-severity " Lukas Wagner
2024-02-28 10:01 ` [pve-devel] [PATCH docs v4 16/18] notification: clarify that 'hostname' does not include the domain Lukas Wagner
2024-02-28 10:01 ` [pve-devel] [PATCH docs v4 17/18] notifications: describe new notification metadata fields Lukas Wagner
2024-02-28 10:01 ` [pve-devel] [PATCH docs v4 18/18] notifications: match-field 'exact'-mode can now match multiple values Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c660e4f-1a2a-43d7-a77c-819ca41c78b7@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox