public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server/docs v2] disable S3/S4 power states by default
Date: Fri, 4 Apr 2025 14:22:10 +0200	[thread overview]
Message-ID: <2c449967-7287-4e6d-939c-633a0eb6d4db@proxmox.com> (raw)
In-Reply-To: <20250307144436.122621-1-d.csapak@proxmox.com>

Am 07.03.25 um 15:44 schrieb Dominik Csapak:
> since they make some problems (e.g. windows hybrid shutdown is enabled
> by default then -> which makes vGPU problem). Libvirt/virsh also
> disables that by default (and tries preventing enabling it.)
> 
> This series introduces a new pve1 version for 9.2 machine versions, and
> pins new windows guests to that. (ignore the edge case for non-version
> pinned machine types on windows, so they'll get always +pve0).
> 
> Additionally I introduce 'enable-s{3,4}' settings so that users can
> still manually enable that (in case it's needed), or disable it for
> older machine types. (non hotpluggable).
> 
> I deliberately did not introduce a GUI option for the enabling of
> S3/S4 power states, since I don't think it'll come up often.
> (If it does, we can still add something to the UI)

Except for the need to adapt the new tests, all just non-functional
nits. So with or without those:

Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-04-04 12:22 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-07 14:44 Dominik Csapak
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 1/8] tests: cfg2cmd: add test for windows machine pinning from meta info Dominik Csapak
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 2/8] config to command: get rid of globalFlags Dominik Csapak
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 3/8] machine: correctly select pve machine version for non pinned windows guests Dominik Csapak
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 4/8] machine: incorporate pve machine version when pinning " Dominik Csapak
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 5/8] machine: add S3/S4 power state properties Dominik Csapak
2025-04-04 11:53   ` Fiona Ebner
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 6/8] machine: bump pve machine version and reverse the s3/s4 defaults Dominik Csapak
2025-04-04 11:54   ` Fiona Ebner
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 7/8] api: qemu machine capabilities: add custom pveX versions too Dominik Csapak
2025-04-04 12:02   ` Fiona Ebner
2025-03-07 14:44 ` [pve-devel] [PATCH qemu-server v2 8/8] api: qemu machine capabilities: add description for pveX variants Dominik Csapak
2025-04-04 12:04   ` Fiona Ebner
2025-04-04 12:24   ` Fiona Ebner
2025-03-07 14:44 ` [pve-devel] [PATCH docs v2 1/1] qm: pve machine version: add section to explain +pveX versions Dominik Csapak
2025-04-04 12:20   ` Fiona Ebner
2025-04-01  9:17 ` [pve-devel] [PATCH qemu-server/docs v2] disable S3/S4 power states by default Dominik Csapak
2025-04-04 12:22 ` Fiona Ebner [this message]
2025-04-04 13:23 ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c449967-7287-4e6d-939c-633a0eb6d4db@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal