public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [RFC manager] triggers: add path-based trigger interest
Date: Mon, 11 Nov 2024 18:44:49 +0100	[thread overview]
Message-ID: <2c3fccc0-d515-486d-b517-63efa9666ee8@proxmox.com> (raw)
In-Reply-To: <20241105114338.473274-1-f.gruenbichler@proxmox.com>

Am 05.11.24 um 12:43 schrieb Fabian Grünbichler:
> to avoid the need to mark every package shipping PVE-related perl code as
> activating the explicit trigger. the explicit trigger can still be used for
> packages that need to reload the API without shipping a perl module
> 
> the explicit trigger activation can be dropped in PVE 9.0 in packages that ship
> perl code, without a need for versioned dependencies.

Not for the HA usecase.

> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> Currently, the following packages ship perl modules in /usr/share/perl5/PVE,
> but don't activate the explicit trigger:
> 
> libpve-apiclient-perl libpve-cluster-perl libpve-notify-perl pve-cluster libpve-u2f-server-perl dab

At least for libpve-notify-perl it might be nice to get a trigger so that HA
get's restarted there too, most of the rest it would be rather superfluous for
HA.

> 
> libpve-cluster-perl is upgraded in lockstep with libpve-cluster-api-perl, which does activate the trigger.
> 
> manually tested reinstalling `pve-cluster` with and without this patch, seems to work as expected.
> 
> are there other paths that might make sense to "watch"?
> 
>  debian/triggers | 1 +
>  1 file changed, 1 insertion(+)
> 
>

applied, thanks!

Korrigieren

Schließen

Rechtschreibung

Possible spelling mistake found.

use caseIgnorieren



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2024-11-11 17:44 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-05 11:43 [pve-devel] " Fabian Grünbichler
2024-11-11 17:44 ` Thomas Lamprecht [this message]
2024-11-12  9:11   ` [pve-devel] applied: " Fabian Grünbichler
2024-11-12  9:52     ` Thomas Lamprecht
2024-11-12 10:28       ` Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2c3fccc0-d515-486d-b517-63efa9666ee8@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal