Re: [pve-devel] [PATCH qemu-server 2/2] enable io-uring support

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

On 07.06.21 13:48, Stefan Reiter wrote:
> Note that the value in this enum directly represents the value passed to
> QEMU, so we need to use the underscore.
> 
> Off by default, updated QEMU required, but no compatibility issues, as
> this is a new value that wasn't valid before, and setting it is the
> users choice.
> 
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
> 
> We probably want this in the GUI as well, there isn't even an option for 'aio'
> in general atm. Thought I'd send it out without just for testing and getting the
> conversation going.
> 
> On a side note, I feel like exposing an option called "threads" when we already
> have "iothread" as well might get confusing.
> 
> Also, if it works well, we could probably make this the default later (probably
> not a great idea for 7.0 though?).

Why not, we get a beta there and it's a new major release, it's at least better
there than 7.1 which should be more stable, so IMO now is one of the better times
to do such a switch.

So, I think that if you found nothing with your testing we should enable it as
default, but naturally not baked in, changing it back should be allowed, that way
users can also temporarily workaround any possible issue we did not found yet.

> 
>  PVE/QemuServer/Drive.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/PVE/QemuServer/Drive.pm b/PVE/QemuServer/Drive.pm
> index 146a4ab..82a6bfe 100644
> --- a/PVE/QemuServer/Drive.pm
> +++ b/PVE/QemuServer/Drive.pm
> @@ -116,7 +116,7 @@ my %drivedesc_base = (
>      },
>      aio => {
>  	type => 'string',
> -	enum => [qw(native threads)],
> +	enum => [qw(native threads io_uring)],
>  	description => 'AIO type to use.',
>  	optional => 1,
>      },
>