* [pve-devel] [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices
@ 2022-11-09 15:37 Daniel Tschlatscher
2022-11-16 18:58 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Tschlatscher @ 2022-11-09 15:37 UTC (permalink / raw)
To: pve-devel
From: Oguz Bektas <o.bektas@proxmox.com>
we already have the 'mtu' option in the API, so we can just expose
that option inside the 'Advanced' menu for virtio network interfaces.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Moved the message tooltip below the advanced columns to avoid the line
break and make it more visually pleasing.
Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
---
Changes from v6
* The message tooltip is now in the advancedColumnB
www/manager6/qemu/NetworkEdit.js | 36 ++++++++++++++++++++++++++++++++
1 file changed, 36 insertions(+)
diff --git a/www/manager6/qemu/NetworkEdit.js b/www/manager6/qemu/NetworkEdit.js
index b39cffdc..86067707 100644
--- a/www/manager6/qemu/NetworkEdit.js
+++ b/www/manager6/qemu/NetworkEdit.js
@@ -19,6 +19,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
me.network.macaddr = values.macaddr;
me.network.disconnect = values.disconnect;
me.network.queues = values.queues;
+ me.network.mtu = values.mtu;
if (values.rate) {
me.network.rate = values.rate;
@@ -33,6 +34,17 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
return params;
},
+ viewModel: {
+ data: {
+ networkModel: '',
+ mtu: '',
+ },
+ formulas: {
+ isVirtio: get => get('networkModel') === 'virtio',
+ showMtuHint: get => get('mtu') === 1,
+ },
+ },
+
setNetwork: function(confid, data) {
var me = this;
@@ -93,6 +105,18 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
fieldLabel: gettext('Disconnect'),
name: 'disconnect',
},
+ {
+ xtype: 'proxmoxintegerfield',
+ name: 'mtu',
+ fieldLabel: 'MTU',
+ bind: {
+ disabled: '{!isVirtio}',
+ value: '{mtu}',
+ },
+ minValue: 1,
+ maxValue: 65520,
+ allowBlank: true,
+ },
];
if (me.insideWizard) {
@@ -112,6 +136,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
'macaddr',
'rate',
'queues',
+ 'mtu',
];
fields.forEach(function(fieldname) {
me.down('field[name='+fieldname+']').setDisabled(value);
@@ -130,6 +155,7 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
xtype: 'pveNetworkCardSelector',
name: 'model',
fieldLabel: gettext('Model'),
+ bind: '{networkModel}',
value: PVE.qemu.OSDefaults.generic.networkCard,
allowBlank: false,
},
@@ -162,6 +188,16 @@ Ext.define('PVE.qemu.NetworkInputPanel', {
allowBlank: true,
},
];
+ me.advancedColumnB = [
+ {
+ xtype: 'displayfield',
+ userCls: 'pmx-hint',
+ value: gettext("Use the special value '1' to inherit the MTU value from the underlying bridge"),
+ bind: {
+ hidden: '{!showMtuHint}',
+ },
+ },
+ ];
me.callParent();
},
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices
2022-11-09 15:37 [pve-devel] [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices Daniel Tschlatscher
@ 2022-11-16 18:58 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-16 18:58 UTC (permalink / raw)
To: Proxmox VE development discussion, Daniel Tschlatscher
Am 09/11/2022 um 16:37 schrieb Daniel Tschlatscher:
> From: Oguz Bektas <o.bektas@proxmox.com>
>
> we already have the 'mtu' option in the API, so we can just expose
> that option inside the 'Advanced' menu for virtio network interfaces.
>
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
>
> Moved the message tooltip below the advanced columns to avoid the line
> break and make it more visually pleasing.
>
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
> ---
> Changes from v6
> * The message tooltip is now in the advancedColumnB
>
> www/manager6/qemu/NetworkEdit.js | 36 ++++++++++++++++++++++++++++++++
> 1 file changed, 36 insertions(+)
>
>
applied, thanks! The hint may be a bit subtle though, as its only shown if
one gets the idea to enter "1" in the first place; but really not a blocker.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-16 18:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-09 15:37 [pve-devel] [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices Daniel Tschlatscher
2022-11-16 18:58 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox