public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Daniel Tschlatscher <d.tschlatscher@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager v7] ui: vm network: allow to override MTU for virtio devices
Date: Wed, 16 Nov 2022 19:58:44 +0100	[thread overview]
Message-ID: <2bfe5e65-c575-064e-6f79-cf78f460d50b@proxmox.com> (raw)
In-Reply-To: <20221109153709.677876-1-d.tschlatscher@proxmox.com>

Am 09/11/2022 um 16:37 schrieb Daniel Tschlatscher:
> From: Oguz Bektas <o.bektas@proxmox.com>
> 
> we already have the 'mtu' option in the API, so we can just expose
> that option inside the 'Advanced' menu for virtio network interfaces.
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> 
> Moved the message tooltip below the advanced columns to avoid the line
> break and make it more visually pleasing.
> 
> Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
> ---
> Changes from v6
> * The message tooltip is now in the advancedColumnB
> 
>  www/manager6/qemu/NetworkEdit.js | 36 ++++++++++++++++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 
>

applied, thanks! The hint may be a bit subtle though, as its only shown if
one gets the idea to enter "1" in the first place; but really not a blocker.




      reply	other threads:[~2022-11-16 18:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-09 15:37 [pve-devel] " Daniel Tschlatscher
2022-11-16 18:58 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2bfe5e65-c575-064e-6f79-cf78f460d50b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.tschlatscher@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal