public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH-SERIES v2 guest-common] replication improvements
Date: Thu, 11 Apr 2024 18:18:55 +0200	[thread overview]
Message-ID: <2be8a5c9-ef51-4b97-8c17-2e796c9f2801@proxmox.com> (raw)
In-Reply-To: <20231213141747.679613-1-f.ebner@proxmox.com>

On 13/12/2023 15:17, Fiona Ebner wrote:
> Improve error when finding a common base snapshot and fix the check if
> a snapshot is needed by replication when there are volumes with
> replicate setting turned off.
> 
> First version:
> https://lists.proxmox.com/pipermail/pve-devel/2023-January/055513.html
> 
> Changes since v1:
>     * add an additional fix
> 
> Fiona Ebner (3):
>   replication: prepare: include volumes without snapshots in the result
>   replication: find common base: improve error when no common base
>     snapshot exists
>   abstract config: fix snapshot needed by replication check
> 
>  src/PVE/AbstractConfig.pm |  2 +-
>  src/PVE/Replication.pm    | 17 ++++++++++++-----
>  2 files changed, 13 insertions(+), 6 deletions(-)
> 


applied, thanks!

Had some slight reservations about recommending deletion of volumes to
user, but maybe I'm to paranoid about them not reading the "target" part
and disregarding any basic sense..




      parent reply	other threads:[~2024-04-11 16:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 14:17 [pve-devel] " Fiona Ebner
2023-12-13 14:17 ` [pve-devel] [PATCH v2 guest-common 1/3] replication: prepare: include volumes without snapshots in the result Fiona Ebner
2023-12-13 14:17 ` [pve-devel] [PATCH v2 guest-common 2/3] replication: find common base: improve error when no common base snapshot exists Fiona Ebner
2023-12-13 14:17 ` [pve-devel] [PATCH v2 guest-common 3/3] abstract config: fix snapshot needed by replication check Fiona Ebner
2024-04-11 11:58 ` [pve-devel] [PATCH-SERIES v2 guest-common] replication improvements Fiona Ebner
2024-04-11 16:18 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2be8a5c9-ef51-4b97-8c17-2e796c9f2801@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal