From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] drive: volume in-use check: fix fallback path comparison
Date: Sun, 18 Apr 2021 18:00:10 +0200 [thread overview]
Message-ID: <2bdd3dc6-d7bd-6b41-1d58-e44d56664575@proxmox.com> (raw)
In-Reply-To: <20210415101057.2836-1-f.ebner@proxmox.com>
On 15.04.21 12:10, Fabian Ebner wrote:
> When checking whether a volume is still referenced by a snapshot, the void
> itself is first checked. When the volid is different, we fall back to comparing
> the path.
>
> As the first value to be compared is a volume's path, the second value better be
> a volume's path too, and not a snapshot's path.
>
> See also 77019edfe0c190c949cdc0b0e3b4ad2ca37313b3 for historical context.
>
> The error that led me here:
> * had a VM with ZFS over iSCSI storage with an exsiting snapshot
> * add new unused drive
> * try to remove the unsued drive
> * fails, because ZFS (not Pool!) Plugin does not support snapshot paths.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/QemuServer/Drive.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks! But see my other mail to this patch for a potential follow-up
prev parent reply other threads:[~2021-04-18 16:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 10:10 [pve-devel] " Fabian Ebner
2021-04-18 15:30 ` Thomas Lamprecht
2021-04-18 16:00 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bdd3dc6-d7bd-6b41-1d58-e44d56664575@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox