From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH storage 2/2] tests: zfs: complain when a first sub-test dies
Date: Mon, 15 Mar 2021 13:57:48 +0100 [thread overview]
Message-ID: <2b7f2399-ef88-6162-c7d6-91fb7ff3b096@proxmox.com> (raw)
In-Reply-To: <20210312095027.19451-2-f.ebner@proxmox.com>
On 12.03.21 10:50, Fabian Ebner wrote:
> Previously, $count was not increased and no test failure was reported.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> Found by messing up in the previous patch at first with:
> my $res = map { $_ => [] } keys %{$ids};
> instead of
> my $res = { map { $_ => [] } keys %{$ids} };
> and wondering why it failed in "production", but the test ran through.
>
> test/run_test_zfspoolplugin.pl | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>
applied, thanks!
next prev parent reply other threads:[~2021-03-15 12:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 9:50 [pve-devel] [PATCH storage 1/2] vdisk list: only collect images from storages with an appropriate content type Fabian Ebner
2021-03-12 9:50 ` [pve-devel] [PATCH storage 2/2] tests: zfs: complain when a first sub-test dies Fabian Ebner
2021-03-15 12:57 ` Thomas Lamprecht [this message]
2021-03-15 12:34 ` [pve-devel] [PATCH storage 1/2] vdisk list: only collect images from storages with an appropriate content type Thomas Lamprecht
2021-03-15 12:57 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b7f2399-ef88-6162-c7d6-91fb7ff3b096@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox