[pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

[pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

[Aaron Lauterer]

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
 www/manager6/storage/DirEdit.js | 4 ++++
 www/manager6/storage/LVMEdit.js | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
index 7e9ec44d..8469a7c3 100644
--- a/www/manager6/storage/DirEdit.js
+++ b/www/manager6/storage/DirEdit.js
@@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
 		name: 'shared',
 		uncheckedValue: 0,
 		fieldLabel: gettext('Shared'),
+		autoEl: {
+		    tag: 'div',
+		    'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
+		}
 	    },
 	];
 
diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
index 75c7bdb8..0d9efd21 100644
--- a/www/manager6/storage/LVMEdit.js
+++ b/www/manager6/storage/LVMEdit.js
@@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
 	    name: 'shared',
 	    uncheckedValue: 0,
 	    fieldLabel: gettext('Shared'),
+	    autoEl: {
+		tag: 'div',
+		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
+	    }
 	},
     ],
 });
-- 
2.39.2

Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

[Fiona Ebner]

Am 21.08.23 um 12:06 schrieb Aaron Lauterer:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>  www/manager6/storage/DirEdit.js | 4 ++++
>  www/manager6/storage/LVMEdit.js | 4 ++++
>  2 files changed, 8 insertions(+)
> 
> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
> index 7e9ec44d..8469a7c3 100644
> --- a/www/manager6/storage/DirEdit.js
> +++ b/www/manager6/storage/DirEdit.js
> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>  		name: 'shared',
>  		uncheckedValue: 0,
>  		fieldLabel: gettext('Shared'),
> +		autoEl: {
> +		    tag: 'div',
> +		    'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
> +		}

eslint complains about missing trailing comma

>  	    },
>  	];
>  
> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
> index 75c7bdb8..0d9efd21 100644
> --- a/www/manager6/storage/LVMEdit.js
> +++ b/www/manager6/storage/LVMEdit.js
> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
>  	    name: 'shared',
>  	    uncheckedValue: 0,
>  	    fieldLabel: gettext('Shared'),
> +	    autoEl: {
> +		tag: 'div',
> +		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
> +	    }

eslint complains about missing trailing comma

>  	},
>      ],
>  });

With those fixed:
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

[Aaron Lauterer]

On 10/10/23 15:06, Fiona Ebner wrote:
> Am 21.08.23 um 12:06 schrieb Aaron Lauterer:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>>   www/manager6/storage/DirEdit.js | 4 ++++
>>   www/manager6/storage/LVMEdit.js | 4 ++++
>>   2 files changed, 8 insertions(+)
>>
>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>> index 7e9ec44d..8469a7c3 100644
>> --- a/www/manager6/storage/DirEdit.js
>> +++ b/www/manager6/storage/DirEdit.js
>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>>   		name: 'shared',
>>   		uncheckedValue: 0,
>>   		fieldLabel: gettext('Shared'),
>> +		autoEl: {
>> +		    tag: 'div',
>> +		    'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>> +		}
> 
> eslint complains about missing trailing comma

hmm, when did that happen... now it does it too for me. Will send another version with it fixed.
> 
>>   	    },
>>   	];
>>   
>> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
>> index 75c7bdb8..0d9efd21 100644
>> --- a/www/manager6/storage/LVMEdit.js
>> +++ b/www/manager6/storage/LVMEdit.js
>> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
>>   	    name: 'shared',
>>   	    uncheckedValue: 0,
>>   	    fieldLabel: gettext('Shared'),
>> +	    autoEl: {
>> +		tag: 'div',
>> +		'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
>> +	    }
> 
> eslint complains about missing trailing comma
> 
>>   	},
>>       ],
>>   });
> 
> With those fixed:
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>

Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared

[Thomas Lamprecht]

Am 10/10/2023 um 15:19 schrieb Aaron Lauterer:
>>>
>>>
>>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>>> index 7e9ec44d..8469a7c3 100644
>>> --- a/www/manager6/storage/DirEdit.js
>>> +++ b/www/manager6/storage/DirEdit.js
>>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>>>           name: 'shared',
>>>           uncheckedValue: 0,
>>>           fieldLabel: gettext('Shared'),
>>> +        autoEl: {
>>> +            tag: 'div',
>>> +            'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>>> +        }
>>
>> eslint complains about missing trailing comma
> 
> hmm, when did that happen... now it does it too for me. Will send another version with it fixed.

We always had that rule enabled, it's a warning one, so `make install` will
only output the warning but continue, to make modify-build-test cycles easier,
but when building a debian package all the eslint warnings become errors.

There's a slight possibility that an earlier eslint had a false-negative here,
but tbh., I'd find that a bit odd as it's a relatively simple check.