From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2] ui: DirEdit: LVMEdit: add hint when to enable shared
Date: Tue, 10 Oct 2023 15:19:28 +0200 [thread overview]
Message-ID: <2b5d69b7-24e5-409d-8781-30ca2914c800@proxmox.com> (raw)
In-Reply-To: <d1ac31cd-ef4c-e59c-c5a3-38f849c7a271@proxmox.com>
On 10/10/23 15:06, Fiona Ebner wrote:
> Am 21.08.23 um 12:06 schrieb Aaron Lauterer:
>> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
>> ---
>> www/manager6/storage/DirEdit.js | 4 ++++
>> www/manager6/storage/LVMEdit.js | 4 ++++
>> 2 files changed, 8 insertions(+)
>>
>> diff --git a/www/manager6/storage/DirEdit.js b/www/manager6/storage/DirEdit.js
>> index 7e9ec44d..8469a7c3 100644
>> --- a/www/manager6/storage/DirEdit.js
>> +++ b/www/manager6/storage/DirEdit.js
>> @@ -30,6 +30,10 @@ Ext.define('PVE.storage.DirInputPanel', {
>> name: 'shared',
>> uncheckedValue: 0,
>> fieldLabel: gettext('Shared'),
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Enable if the underlying file system is already shared between nodes.'),
>> + }
>
> eslint complains about missing trailing comma
hmm, when did that happen... now it does it too for me. Will send another version with it fixed.
>
>> },
>> ];
>>
>> diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js
>> index 75c7bdb8..0d9efd21 100644
>> --- a/www/manager6/storage/LVMEdit.js
>> +++ b/www/manager6/storage/LVMEdit.js
>> @@ -227,6 +227,10 @@ Ext.define('PVE.storage.LVMInputPanel', {
>> name: 'shared',
>> uncheckedValue: 0,
>> fieldLabel: gettext('Shared'),
>> + autoEl: {
>> + tag: 'div',
>> + 'data-qtip': gettext('Enable if the LVM is located on a shared LUN.'),
>> + }
>
> eslint complains about missing trailing comma
>
>> },
>> ],
>> });
>
> With those fixed:
> Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
next prev parent reply other threads:[~2023-10-10 13:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 10:06 Aaron Lauterer
2023-10-10 13:06 ` Fiona Ebner
2023-10-10 13:19 ` Aaron Lauterer [this message]
2023-10-10 14:31 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b5d69b7-24e5-409d-8781-30ca2914c800@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox