public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v6 4/5] added clipboard checkbox to VM Options
Date: Thu, 20 Apr 2023 18:12:39 +0200	[thread overview]
Message-ID: <2ab8625a-4b7a-40d9-eaed-4b7800141d81@proxmox.com> (raw)
In-Reply-To: <20230419064348.11953-5-m.frank@proxmox.com>

Can confirm the "vga type is not compatible ..." issue from v5 is gone,
and I do like the new `vnc_clipboard` name -- thanks!

I noticed two small glitches, though I'm not sure if they are that
important.

Glitch #1:
1) Create VM with default VGA options: Hardware->Display shows "Default"
2) Enable noVNC clipboard: "Display" shows "Default (vnc_clipboard=1)"
3) Disable noVNC clipboard: "Display" is now empty, where I would expect
it to flip back to "Default"
I guess the reason is that step 3 produces a `vga:` entry in the VM
config. AFAICT, functionality is not affected, the empty "Display" just
looks a bit weird.

Glitch #2:
1) Debian VM with XFCE and spice-vdagent 0.20.0, also install xclip
2) Type "x" in noVNC clipboard window
3) Inside the VM, run:
```
$ xclip -o -selection clipboard | xxd
00000000: 7800                                     x.
```
Note the additional null byte after the x -- this probably shouldn't be
there. I'm not sure what the cause is, maybe it's something on my system
(I'm using Firefox), or spice-vdagent?




  reply	other threads:[~2023-04-20 16:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-19  6:43 [pve-devel] [PATCH qemu-server/manager/novnc/docs v6 0/5] Feature noVNC-Clipboard Markus Frank
2023-04-19  6:43 ` [pve-devel] [PATCH qemu-server v6 1/5] enable clipboard parameter in vga_fmt Markus Frank
2023-04-19  6:43 ` [pve-devel] [PATCH qemu-server v6 2/5] test cases for clipboard spice & std Markus Frank
2023-04-19  6:43 ` [pve-devel] [PATCH novnc v6 3/5] added show clipboard button patch to series Markus Frank
2023-04-19  6:43 ` [pve-devel] [PATCH manager v6 4/5] added clipboard checkbox to VM Options Markus Frank
2023-04-20 16:12   ` Friedrich Weber [this message]
2023-04-21 10:24     ` Friedrich Weber
2023-04-19  6:43 ` [pve-devel] [PATCH docs v6 5/5] added noVNC clipboard documentation Markus Frank

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ab8625a-4b7a-40d9-eaed-4b7800141d81@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal