From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lucas Barros <lucasbarros.kam@gmail.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH cluster/qemu-server/common v2 0/3] fix #6357: parse all search domains of resolv.conf
Date: Mon, 16 Nov 2026 02:48:14 +0100 [thread overview]
Message-ID: <2a8fd3fe-81dd-406e-83fc-4d8f97369eac@proxmox.com> (raw)
In-Reply-To: <20261116010014.88737-1-lucasbarros.kam@gmail.com>
Thanks for the v2, still some issues though, see below.
Am 16.11.26 um 02:00 schrieb Lucas Barros:
> The resolv.conf parser in pve-common only keeps the first domain of the
> 'search' line, so the DNS panel of a node shows only that one and saving
> it again drops the others.
>
> Thomas pointed out that the node certificate appends the value to the
> node name [0]. I went through all users of the value (and of FQDNs
> built from a search list) and used one rule: the API and the guests'
> DNS settings get the whole list, an FQDN only uses the first domain.
> That is what the certificates got so far, as the parser only returned
> the first domain.
>
> * 1/3 pve-cluster: node certificate uses the first domain; has to be
> applied before 3/3
> * 2/3 qemu-server: cloud-init 'fqdn' used the whole 'searchdomain' of
> the VM ('vm.a.example b.example'); independent of 3/3, same mistake
> * 3/3 pve-common: the parser fix, unchanged code from v1
Please sent v2 as new thread, i.e. without in-reply-to header for the
previous revision. A reply to the old thread with a superseded: in
the subject and
superseded-by: https://lore.proxmox.com/pve-devel/20261107223019.21361-1-lucasbarros.kam@gmail.com/
in the body then tells all where they can find the new one (git send-email
can be made to generate such a reply too, i.e. your LLM can help here
if in doubt).
Anyway, back to the change at hand:
I overlooked that PMG also uses this and would need changing too, i.e.
in PMG::Config::get_host_dns_info() would and also in
PMG::Utils::gen_proxmox_tls_cert() and pmg-smtp-filter and maybe more.
Starting to think it might be easier to keep this as is, add a new
method with the multi-search-domain behavior and switch over the
API for dns edit to that one?
Oh and resolv.conf(5) specifies that the obsolete domain directive
handles only one search-list entry. The shared branch now treats
"domain a.example b.example" as two domains, whereas the previous parser
retained only "a.example". Consequently, the API and guest fallback
settings can acquire an additional domain that the host resolver does
not use; saving the node DNS settings also converts that value into a
multi-entry search directive. So consider keeping first-token parsing
for domain and applying whole-list parsing only to search. A regression
test with trailing words after a domain entry could cover the
distinction; the current single-domain test cannot detect it.
next prev parent reply other threads:[~2026-11-16 1:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-07 22:30 [PATCH common] fix #6357: inotify: resolv.conf: parse all search domains Lucas Barros
2026-11-11 23:15 ` Thomas Lamprecht
2026-11-16 1:00 ` [PATCH cluster/qemu-server/common v2 0/3] fix #6357: parse all search domains of resolv.conf Lucas Barros
2026-11-16 1:00 ` [PATCH cluster v2 1/3] setup: node certificate: only use the first search domain for the FQDN Lucas Barros
2026-11-16 1:00 ` [PATCH qemu-server v2 2/3] cloudinit: " Lucas Barros
2026-11-16 1:00 ` [PATCH common v2 3/3] fix #6357: inotify: resolv.conf: parse all search domains Lucas Barros
2026-11-16 1:48 ` Thomas Lamprecht [this message]
2026-11-16 13:32 ` superseded: [PATCH cluster/qemu-server/common v2 0/3] fix #6357: parse all search domains of resolv.conf Lucas Barros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8fd3fe-81dd-406e-83fc-4d8f97369eac@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=lucasbarros.kam@gmail.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox