From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
pve-devel@lists.proxmox.com, pmg-devel@lists.proxmox.com
Subject: [pve-devel] partially-applied: [pmg-devel] [PATCH common/pve-manager/pmg-api] unify task filter api
Date: Mon, 28 Jun 2021 16:55:41 +0200 [thread overview]
Message-ID: <2a8cfb24-ee38-9674-0f42-61a2ef640ca5@proxmox.com> (raw)
In-Reply-To: <20210624071016.21013-1-d.csapak@proxmox.com>
On 24.06.21 09:10, Dominik Csapak wrote:
> pmg-api:
>
> Dominik Csapak (3):
> PMG/API2/Tasks: add typefilter
> PMG/API2/Tasks: add since and until filter
> PMG/API2/Tasks: add statusfilter
>
applied above, but adapted commit subject as it made not much sense to me, as:
* PMG is rather obvious in a pmg-api repo, so not much use for the human reader
* s!API2/Tasks!api: tasks!; as the "subsystem" is api, affecting the tasks endpoints,
we do not really care which API version
This almost looks like you just copied over the file changed, which is not really
useful as I can just use `git log --stat` for that, the subject should rather be
as friendly as possible for the human eye, ideally be written such that it can be
copied over 1:1 in d/changelog and be also digestible easily in `git log --oneline`.
prev parent reply other threads:[~2021-06-28 14:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-24 7:10 [pve-devel] " Dominik Csapak
2021-06-24 7:10 ` [pve-devel] [PATCH common 1/2] PVE/JSONSchema: add pve-task-status-type Dominik Csapak
2021-06-28 12:59 ` [pve-devel] applied: [pmg-devel] " Thomas Lamprecht
2021-06-24 7:10 ` [pve-devel] [PATCH common 2/2] PVE/Tools: add 'upid_get_status_type' Dominik Csapak
2021-06-28 13:06 ` [pve-devel] applied: [pmg-devel] " Thomas Lamprecht
2021-06-24 7:10 ` [pve-devel] [PATCH manager 1/2] PVE/API2/Tasks: add since/until filter for the task list Dominik Csapak
2021-06-28 15:53 ` [pve-devel] applied: [pmg-devel] " Thomas Lamprecht
2021-06-24 7:10 ` [pve-devel] [PATCH manager 2/2] PVE/API2/Tasks: add statusfilter to " Dominik Csapak
2021-06-28 15:53 ` [pve-devel] applied: [pmg-devel] " Thomas Lamprecht
2021-06-24 7:10 ` [pve-devel] [PATCH pmg-api 1/3] PMG/API2/Tasks: add typefilter Dominik Csapak
2021-06-24 7:10 ` [pve-devel] [PATCH pmg-api 2/3] PMG/API2/Tasks: add since and until filter Dominik Csapak
2021-06-24 7:10 ` [pve-devel] [PATCH pmg-api 3/3] PMG/API2/Tasks: add statusfilter Dominik Csapak
2021-06-28 14:55 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a8cfb24-ee38-9674-0f42-61a2ef640ca5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pmg-devel@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox