Re: [pve-devel] [RFC qemu-server 15/15] command line: switch to blockdev starting with machine version 10.0

From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [RFC qemu-server 15/15] command line: switch to blockdev starting with machine version 10.0
Date: Tue, 24 Jun 2025 16:34:33 +0200	[thread overview]
Message-ID: <2a7f6404-d376-41d2-9811-f7a8684f0aa2@proxmox.com> (raw)
In-Reply-To: <mailman.591.1750773222.395.pve-devel@lists.proxmox.com>

Am 24.06.25 um 15:53 schrieb DERUMIER, Alexandre via pve-devel:
>>> name":"feb8f022b5551ad1d795611f112c767","read-
>>> only":false,"size":131072},"node-name":"drive-efidisk0","throttle-
>>> group":"throttle-drive-efidisk0"}' \
> 
> It's missing 
> "key-value-pairs":{"rbd-cache-policy":"writeback"}

Would be a good catch ;) But after the recent discussion upstream [0],
the plan is to not patch QEMU, but set the option via RBD in the storage
plugin itself for EFI disks, that's why the hint is still passed along.
I added a comment that it's set via the storage layer in patch 09/15.

[0]:
https://lore.kernel.org/qemu-devel/CAOi1vP81g40nOnskY8fR8Eh7j9JMJdfD=P0+HBVUp80suNQWJQ@mail.gmail.com/

I think I'll send the next version of the storage patches relatively
shortly after part three (still quite a bit of splitting up
QemuServer.pm on the way, e.g for introducing a BlockJob module). I'll
try to send part three in the following days, I hope I get around to
also include blockdev-mirror there.

Part four is then hopefully the final one, doing all the version-guarded
switches and making all features work, fingers crossed :)

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel