From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server 1/3] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s
Date: Thu, 22 Sep 2022 13:51:52 +0200 [thread overview]
Message-ID: <2a4be18f-92ed-876b-8a0f-aa62bba111c0@proxmox.com> (raw)
In-Reply-To: <20220921124911.3224970-2-d.csapak@proxmox.com>
Am 21/09/2022 um 14:49 schrieb Dominik Csapak:
> + fprintf(stderr, " -t timeout kill timeout (default: %ds)\n", DEFAULT_KILL_TIMEOUT);
just a nit, as you probably send a v2 for Fabian's comments anyway:
Please do s/timeout/<s>/ i.e.:
-t <s> kill timeo..
That has two advantages, first the user actually knows the time unit and
second, the context whitespace changes aren't required anymore.
Did not checked the rest more closely, but this stuck out when skimming.
next prev parent reply other threads:[~2022-09-22 11:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-21 12:49 [pve-devel] [PATCH qemu-server 0/3] qmeventd: improve shutdown behaviour Dominik Csapak
2022-09-21 12:49 ` [pve-devel] [PATCH qemu-server 1/3] qmeventd: rework 'forced_cleanup' handling and set timeout to 60s Dominik Csapak
[not found] ` <<20220921124911.3224970-2-d.csapak@proxmox.com>
2022-09-22 8:24 ` Fabian Grünbichler
2022-09-22 11:31 ` Dominik Csapak
2022-09-22 12:01 ` Wolfgang Bumiller
2022-09-22 12:22 ` Dominik Csapak
2022-09-22 12:46 ` Wolfgang Bumiller
2022-09-22 11:51 ` Thomas Lamprecht [this message]
2022-09-21 12:49 ` [pve-devel] [PATCH qemu-server 2/3] qmeventd: cancel 'forced cleanup' when normal cleanup succeeds Dominik Csapak
2022-09-22 10:14 ` Matthias Heiserer
2022-09-22 11:37 ` Dominik Csapak
2022-09-23 7:58 ` Wolfgang Bumiller
2022-09-21 12:49 ` [pve-devel] [PATCH qemu-server 3/3] qmeventd: send QMP 'quit' command instead of SIGTERM Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a4be18f-92ed-876b-8a0f-aa62bba111c0@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox