From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH proxmox-acme 0/2] add missing readdomainconf and helper script
Date: Tue, 26 Apr 2022 10:49:44 +0200 [thread overview]
Message-ID: <2a3ad089-7508-5b1d-91c8-c823599f5092@proxmox.com> (raw)
In-Reply-To: <20220304151059.3787765-1-s.ivanov@proxmox.com>
On 04.03.22 16:10, Stoiko Ivanov wrote:
> The first patch addresses a issue reported in our community forum.
>
> The second patch is meant as a suggestion - and can happily be dropped.
> Since it's the second time I ran into trying to find a sensible diff of what
> is missing in proxmox-acme, but present in upstream acme.sh and adapted
> the grep - I thought it might make sense to have it in the repo.
>
> Stoiko Ivanov (2):
> plugin-caller: add _readdomainconf stub
> add shellscript to find needed functions not provided by proxmox-acme
>
> check-missing-functions | 13 +++++++++++++
> src/proxmox-acme | 5 +++++
> 2 files changed, 18 insertions(+)
> create mode 100755 check-missing-functions
>
applied, thanks!
Reduced false-positives in a followup, moved to the src/test directory and added to the
test make target to compare the output with a known-ok false-positive list tracked in git.
prev parent reply other threads:[~2022-04-26 8:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-04 15:10 [pve-devel] " Stoiko Ivanov
2022-03-04 15:10 ` [pve-devel] [PATCH proxmox-acme 1/2] plugin-caller: add _readdomainconf stub Stoiko Ivanov
2022-03-04 15:10 ` [pve-devel] [PATCH proxmox-acme 2/2] add shellscript to find needed functions not provided by proxmox-acme Stoiko Ivanov
2022-04-26 8:49 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a3ad089-7508-5b1d-91c8-c823599f5092@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox