From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 manager 1/3] ui: restore: disallow empty storage selection if it wouldn't work
Date: Sat, 23 Apr 2022 11:38:35 +0200 [thread overview]
Message-ID: <29993f47-77f1-2701-e8d6-dd11a6b21a29@proxmox.com> (raw)
In-Reply-To: <20220421112659.74011-12-f.ebner@proxmox.com>
On 21.04.22 13:26, Fabian Ebner wrote:
> Namely, if there is a storage in the backup configuration that's not
> available on the current node.
Better than the status quo, but in the long run all the "force all volumes to a single storage"
on restore and also migrate isn't ideal for the case where one or more storages do not exist on
the target node. An per-volume override would be nicer, but may require some gui adaptions to
present that in a sensible way with good UX.
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> New in v2.
>
> www/manager6/window/Restore.js | 34 ++++++++++++++++++++++++++++++++++
> 1 file changed, 34 insertions(+)
>
> diff --git a/www/manager6/window/Restore.js b/www/manager6/window/Restore.js
> index e7b3e945..25babf89 100644
> --- a/www/manager6/window/Restore.js
> +++ b/www/manager6/window/Restore.js
> @@ -15,6 +15,40 @@ Ext.define('PVE.window.Restore', {
> },
> },
> },
> +
> + afterRender: function() {
> + let view = this.getView();
> +
> + Proxmox.Utils.API2Request({
> + url: `/nodes/${view.nodename}/vzdump/extractconfig`,
> + method: 'GET',
> + params: {
> + volume: view.volid,
> + },
> + failure: (response) => Ext.Msg.alert('Error', response.htmlStatus),
nit: no parenthesis required for single parameter arrow fns
> + success: function(response, options) {
> + let storagesAvailable = true;
> +
> + response.result.data.split('\n').forEach(function(line) {
style nit: makes no big difference but for new code we prefer arrow fns for inline closures.
> + let match = line.match(
> + /^#qmdump#map:(\S+):(\S+):(\S*):(\S*):$/,
> + );
fits in 100 cc so would rather keep in in a single line
> + if (match) {
> + let currentAvailable = !!PVE.data.ResourceStore.getById(
> + `storage/${view.nodename}/${match[3]}`,
> + );
> + storagesAvailable = storagesAvailable && currentAvailable;
JS has a &&= operator, so could be:
storagesAvailable &&= !!PVE.data.ResourceStore.getById(
`storage/${view.nodename}/${match[3]}`);
but as we only want to do one thing if any storage is not available we could do:
```
let allStoragesAvailable = response.result.data.split('\n').every(line => {
let match = line.match(/^#qmdump#map:(\S+):(\S+):(\S*):(\S*):$/);
if (match) {
return !!PVE.data.ResourceStore.getById(`storage/${view.nodename}/${match[3]}`);
}
return true;
}
if (!allStoragesAvailable) {
// ...
}
```
IMO a bit easier to follow.
> + }
> + });
> +
> + if (!storagesAvailable) {
> + let storagesel = view.down('pveStorageSelector[name=storage]');
> + storagesel.allowBlank = false;
> + storagesel.setEmptyText('');
> + }
> + },
> + });
> + },
> },
>
> initComponent: function() {
next prev parent reply other threads:[~2022-04-23 9:38 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-21 11:26 [pve-devel] [PATCH-SERIES v2 qemu/qemu-server/widget-toolkit/manager] more flexible restore Fabian Ebner
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu 1/2] vma: restore: call blk_unref for all opened block devices Fabian Ebner
2022-04-25 6:37 ` Wolfgang Bumiller
2022-04-25 16:10 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu 2/2] vma: allow partial restore Fabian Ebner
2022-04-25 6:40 ` Wolfgang Bumiller
2022-04-25 16:10 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 1/7] restore: cleanup oldconf: also clean up snapshots from kept volumes Fabian Ebner
2022-04-25 16:20 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 2/7] restore destroy volumes: remove check for absolute path Fabian Ebner
2022-04-25 16:20 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 3/7] restore deactivate volumes: never die Fabian Ebner
2022-04-23 9:18 ` Thomas Lamprecht
2022-04-25 6:45 ` Fabian Ebner
2022-04-25 16:21 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 4/7] restore: also deactivate/destroy cloud-init disk upon error Fabian Ebner
2022-04-25 16:21 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 5/7] api: create: refactor parameter check logic Fabian Ebner
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 6/7] api: create: allow overriding non-disk options during restore Fabian Ebner
2022-04-21 11:26 ` [pve-devel] [PATCH v2 qemu-server 7/7] restore: allow preserving drives " Fabian Ebner
2022-04-21 11:26 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] css: add proxmox-good-row class Fabian Ebner
2022-04-23 8:32 ` [pve-devel] applied: " Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 manager 1/3] ui: restore: disallow empty storage selection if it wouldn't work Fabian Ebner
2022-04-23 9:38 ` Thomas Lamprecht [this message]
2022-04-25 7:28 ` Fabian Ebner
2022-04-27 7:05 ` Thomas Lamprecht
2022-04-27 8:21 ` Fabian Ebner
2022-04-21 11:26 ` [pve-devel] [PATCH v2 manager 2/3] ui: restore: allow override of some settings Fabian Ebner
2022-04-23 10:07 ` Thomas Lamprecht
2022-04-21 11:26 ` [pve-devel] [PATCH v2 manager 3/3] ui: restore: allow preserving disks Fabian Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29993f47-77f1-2701-e8d6-dd11a6b21a29@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox