From: Fiona Ebner <f.ebner@proxmox.com>
To: Arthur Bied-Charreton <a.bied-charreton@proxmox.com>,
pve-devel@lists.proxmox.com
Subject: Re: [PATCH manager/qemu-server 0/3] custom cpu models: tighten reported-model handling
Date: Tue, 19 May 2026 16:50:22 +0200 [thread overview]
Message-ID: <297a293b-beff-4f85-96f8-496d1aa634d6@proxmox.com> (raw)
In-Reply-To: <20260519140623.594472-1-a.bied-charreton@proxmox.com>
Am 19.05.26 um 4:06 PM schrieb Arthur Bied-Charreton:
> The default reported-model for custom CPU models is kvm64, a legacy
> model with a limited set of features.
>
> This series tightens the handling around reported-model:
>
> 1. Require reported-model on creation via the API, as the UI already
> does
> 2. Prevent deletion of reported-model via PUT
> 3. Resolve and write out the default explicitly on config writes
>
> This will be useful in case we ever want to make reported-model
> required in a future major release.
Nit: the Suggested-by trailer should come before the Signed-off-by to
keep the chronological order.
Regarding patch 1: it is a breaking change, but the feature has only
been on no-subscription for a few days and I suspect most people would
use the UI or specify an explicit model anyways.
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
prev parent reply other threads:[~2026-05-19 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 14:06 [PATCH manager/qemu-server 0/3] custom cpu models: tighten reported-model handling Arthur Bied-Charreton
2026-05-19 14:06 ` [PATCH pve-manager 1/3] custom cpu models: make 'reported-model' required in POST Arthur Bied-Charreton
2026-05-19 14:06 ` [PATCH pve-manager 2/3] custom cpu models: do not allow deleting 'reported-model' Arthur Bied-Charreton
2026-05-19 14:06 ` [PATCH qemu-server 3/3] cpu config: resolve default reported-model on write Arthur Bied-Charreton
2026-05-19 14:50 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=297a293b-beff-4f85-96f8-496d1aa634d6@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.bied-charreton@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox