public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH installer] license: Improve "For more information" paragraph
@ 2024-11-19 10:30 Maximiliano Sandoval
  2024-11-19 11:03 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2024-11-19 10:30 UTC (permalink / raw)
  To: pve-devel

The sentence is phrased in a way which is not completely clear.

This matches the Backup Server license more closely:

        For more information, visit <b>www.proxmox.com</b>
        or the Proxmox Backup Server project page.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
Other alternatives:
 - Remove the mention of the wiki altogether
 - Say "the Proxmox VE project page" instead of the wiki

I opted for the current approach because it says the same in an easier to read
way.

 html/pve/extract1-license.htm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/html/pve/extract1-license.htm b/html/pve/extract1-license.htm
index 87963ab..9882068 100644
--- a/html/pve/extract1-license.htm
+++ b/html/pve/extract1-license.htm
@@ -23,8 +23,8 @@
 	- Live Migration<br>
 	- 32 and 64 bit guests<br><br>
 
-	Visit <b>www.proxmox.com</b>
-	for additional information and the Wiki about Proxmox VE.
+	For more information, visit <b>www.proxmox.com</b>
+	or the Proxmox VE wiki.
 	<br><br>
       </td></tr>
     </table>
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* [pve-devel] applied: [PATCH installer] license: Improve "For more information" paragraph
  2024-11-19 10:30 [pve-devel] [PATCH installer] license: Improve "For more information" paragraph Maximiliano Sandoval
@ 2024-11-19 11:03 ` Thomas Lamprecht
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-19 11:03 UTC (permalink / raw)
  To: Proxmox VE development discussion, Maximiliano Sandoval

Am 19.11.24 um 11:30 schrieb Maximiliano Sandoval:
> The sentence is phrased in a way which is not completely clear.
> 
> This matches the Backup Server license more closely:
> 
>         For more information, visit <b>www.proxmox.com</b>
>         or the Proxmox Backup Server project page.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> Other alternatives:
>  - Remove the mention of the wiki altogether
>  - Say "the Proxmox VE project page" instead of the wiki
> 
> I opted for the current approach because it says the same in an easier to read
> way.

That seems like a good call to me.

> 
>  html/pve/extract1-license.htm | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-11-19 11:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-19 10:30 [pve-devel] [PATCH installer] license: Improve "For more information" paragraph Maximiliano Sandoval
2024-11-19 11:03 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal