From: Dietmar Maurer <dietmar@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Mira Limbeck <m.limbeck@proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-openid-rs] fix Open ID with Azure as provider
Date: Fri, 1 Apr 2022 06:21:21 +0200 (CEST) [thread overview]
Message-ID: <287966750.23.1648786881113@webmail.proxmox.com> (raw)
> let response = if let Method::POST = request.method {
> - req.send(&*request.body)
> + let bytes = request.body.as_slice();
> + req.send_bytes(bytes)
Does this have the side effect of changing the transfer encoding? If so, it is worth to add an inline comment.
next reply other threads:[~2022-04-01 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-01 4:21 Dietmar Maurer [this message]
2022-04-01 8:57 ` Mira Limbeck
-- strict thread matches above, loose matches on Subject: below --
2022-03-31 13:33 Mira Limbeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=287966750.23.1648786881113@webmail.proxmox.com \
--to=dietmar@proxmox.com \
--cc=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox