From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Leo Nunner <l.nunner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v2 storage] config: add overrides for default directory locations
Date: Thu, 5 Jan 2023 14:54:27 +0100 [thread overview]
Message-ID: <27a763c0-95ff-d1c4-e88a-07eb87ca3e13@proxmox.com> (raw)
In-Reply-To: <20230102160438.180285-2-l.nunner@proxmox.com>
Am 02/01/2023 um 17:04 schrieb Leo Nunner:
> Allowing overrides for the default directory locations seems to
> integrate rather well into the existing system. Custom locations
> are specified using the "dirs" parameter as a comma-separated list
> of "vtype:/location" values.
>
> For now, the option has been enabled for the Directory, CIFS and NFS
> backends.
>
> Signed-off-by: Leo Nunner <l.nunner@proxmox.com>
> ---
> PVE/Storage/CIFSPlugin.pm | 1 +
> PVE/Storage/DirPlugin.pm | 1 +
> PVE/Storage/NFSPlugin.pm | 1 +
> PVE/Storage/Plugin.pm | 49 +++++++++++++++++++++++++++++++++++----
> test/get_subdir_test.pm | 7 ++++++
> 5 files changed, 55 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/Storage/CIFSPlugin.pm b/PVE/Storage/CIFSPlugin.pm
> index 982040a..4284c35 100644
> --- a/PVE/Storage/CIFSPlugin.pm
> +++ b/PVE/Storage/CIFSPlugin.pm
> @@ -128,6 +128,7 @@ sub properties {
> sub options {
> return {
> path => { fixed => 1 },
> + dirs => { optional => 1 },
> server => { fixed => 1 },
> share => { fixed => 1 },
> nodes => { optional => 1 },
> diff --git a/PVE/Storage/DirPlugin.pm b/PVE/Storage/DirPlugin.pm
> index 8715a9d..3c907ca 100644
> --- a/PVE/Storage/DirPlugin.pm
> +++ b/PVE/Storage/DirPlugin.pm
> @@ -54,6 +54,7 @@ sub properties {
> sub options {
> return {
> path => { fixed => 1 },
> + dirs => { optional => 1 },
> nodes => { optional => 1 },
> shared => { optional => 1 },
> disable => { optional => 1 },
> diff --git a/PVE/Storage/NFSPlugin.pm b/PVE/Storage/NFSPlugin.pm
> index 5bd7313..b7e8318 100644
> --- a/PVE/Storage/NFSPlugin.pm
> +++ b/PVE/Storage/NFSPlugin.pm
> @@ -79,6 +79,7 @@ sub properties {
> sub options {
> return {
> path => { fixed => 1 },
> + dirs => { optional => 1 },
> server => { fixed => 1 },
> export => { fixed => 1 },
> nodes => { optional => 1 },
> diff --git a/PVE/Storage/Plugin.pm b/PVE/Storage/Plugin.pm
> index 8a41df1..5cb3d90 100644
> --- a/PVE/Storage/Plugin.pm
> +++ b/PVE/Storage/Plugin.pm
> @@ -181,6 +181,11 @@ my $defaultData = {
> default => 'metadata',
> optional => 1,
> },
> + dirs => {
"content-dirs" for more clarity?
> + description => "Overrides for default directories",
"[...] default content type directories"
> + type => "string", format => "pve-dir-override-list",
please also add the default value here
next prev parent reply other threads:[~2023-01-05 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-02 16:04 [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories Leo Nunner
2023-01-02 16:04 ` [pve-devel] [PATCH v2 storage] config: add overrides for default directory locations Leo Nunner
2023-01-05 13:34 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:54 ` Thomas Lamprecht [this message]
2023-01-02 16:04 ` [pve-devel] [PATCH v2 docs] docs: document 'dirs' parameter for directory storage Leo Nunner
2023-01-05 13:35 ` [pve-devel] applied: " Wolfgang Bumiller
2023-01-05 13:41 ` [pve-devel] [PATCH v2 storage docs] Allow overrides for default directories Wolfgang Bumiller
2023-01-05 13:53 ` Thomas Lamprecht
2023-01-05 14:02 ` Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27a763c0-95ff-d1c4-e88a-07eb87ca3e13@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.nunner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox