From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: [pve-devel] applied: [PATCH] smartmontools.default: add `-q never` to smartd_opts
Date: Fri, 16 Jun 2023 16:53:19 +0200 [thread overview]
Message-ID: <279f07bf-505e-36df-298b-2868b6e6f340@proxmox.com> (raw)
In-Reply-To: <20230616122208.3946516-1-s.ivanov@proxmox.com>
Am 16/06/2023 um 14:22 schrieb Stoiko Ivanov:
> smartmontools has the option to run as 'notify' type systemd.service
> (see `smartd(8)` in bookworm and later), and debian-upstream uses
> this.
> If a system has no monitorable disks (observed in a HP DL380g8, where
> smartd does not seem to work by default with the the smart-array
> controller with a RAID1 configured) the smartmontools.service fails
> because smartd exits with 17.
>
> Adding `-q nodev0`, which should cause the exit not to be considered a
> failure does not work either, because type=notify does not expect the
> daemon to exit (or the daemon exits before notifying systemd)
>
> Tested by installing a version with this patch on the HP DL380g8
> mentioned above, additionally inside a VM running PVE and a workstation
> upgraded to the latest 8.0 beta.
>
> Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
> ---
> debian/smartmontools.default | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-06-16 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 12:22 [pve-devel] " Stoiko Ivanov
2023-06-16 14:53 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279f07bf-505e-36df-298b-2868b6e6f340@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox