[pve-devel] [PATCH qemu-server] vm start: check efi vars: avoid undef Perl warning when no OS type is set

[pve-devel] [PATCH qemu-server] vm start: check efi vars: avoid undef Perl warning when no OS type is set

[Fiona Ebner]

Fixes: c5b3a314 ("fix #6985: ovmf: auto-enroll Microsoft UEFI CA 2023 for Windows")
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 src/PVE/QemuServer.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
index a7fbec14..d634251b 100644
--- a/src/PVE/QemuServer.pm
+++ b/src/PVE/QemuServer.pm
@@ -5421,6 +5421,7 @@ my sub check_efi_vars {
 
     return if PVE::QemuConfig->is_template($conf);
     return if !$conf->{efidisk0};
+    return if !$conf->{ostype};
     return if $conf->{ostype} ne 'win10' && $conf->{ostype} ne 'win11';
 
     if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($conf->{efidisk0})) {
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] vm start: check efi vars: avoid undef Perl warning when no OS type is set

[Thomas Lamprecht]

Am 03.12.25 um 11:35 schrieb Fiona Ebner:
> Fixes: c5b3a314 ("fix #6985: ovmf: auto-enroll Microsoft UEFI CA 2023 for Windows")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>

Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

Consider above for similar future fixes of you, just apply them directly.
You could still send it to the list with an "applied:" prefix already added to
the subject in that submission, if you still want to keep the list/others informed.

> ---
>  src/PVE/QemuServer.pm | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index a7fbec14..d634251b 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -5421,6 +5421,7 @@ my sub check_efi_vars {
>  
>      return if PVE::QemuConfig->is_template($conf);
>      return if !$conf->{efidisk0};
> +    return if !$conf->{ostype};
>      return if $conf->{ostype} ne 'win10' && $conf->{ostype} ne 'win11';
>  
>      if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($conf->{efidisk0})) {



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH qemu-server] vm start: check efi vars: avoid undef Perl warning when no OS type is set

[Fiona Ebner]

Am 03.12.25 um 11:56 AM schrieb Thomas Lamprecht:
> Am 03.12.25 um 11:35 schrieb Fiona Ebner:
>> Fixes: c5b3a314 ("fix #6985: ovmf: auto-enroll Microsoft UEFI CA 2023 for Windows")
>> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> 
> Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> 
> Consider above for similar future fixes of you, just apply them directly.
> You could still send it to the list with an "applied:" prefix already added to
> the subject in that submission, if you still want to keep the list/others informed.

Alright!

Applied as 967064c98f1c7266634f22580bb746deaf249156
"check efi vars: avoid undef Perl warning when no OS type is set"


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel