From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server] vm start: check efi vars: avoid undef Perl warning when no OS type is set
Date: Wed, 3 Dec 2025 11:56:58 +0100 [thread overview]
Message-ID: <279d37d9-24ef-4976-b8cd-63a4461a836b@proxmox.com> (raw)
In-Reply-To: <20251203103616.40637-1-f.ebner@proxmox.com>
Am 03.12.25 um 11:35 schrieb Fiona Ebner:
> Fixes: c5b3a314 ("fix #6985: ovmf: auto-enroll Microsoft UEFI CA 2023 for Windows")
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Consider above for similar future fixes of you, just apply them directly.
You could still send it to the list with an "applied:" prefix already added to
the subject in that submission, if you still want to keep the list/others informed.
> ---
> src/PVE/QemuServer.pm | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index a7fbec14..d634251b 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -5421,6 +5421,7 @@ my sub check_efi_vars {
>
> return if PVE::QemuConfig->is_template($conf);
> return if !$conf->{efidisk0};
> + return if !$conf->{ostype};
> return if $conf->{ostype} ne 'win10' && $conf->{ostype} ne 'win11';
>
> if (PVE::QemuServer::OVMF::should_enroll_ms_2023_cert($conf->{efidisk0})) {
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-12-03 10:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 10:36 Fiona Ebner
2025-12-03 10:56 ` Thomas Lamprecht [this message]
2025-12-04 9:42 ` [pve-devel] applied: " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=279d37d9-24ef-4976-b8cd-63a4461a836b@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox