From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 manager 2/5] fix #3069: vzdump: add property 'performance: pbs-entries-max=N'
Date: Thu, 27 Jul 2023 11:05:28 +0200 [thread overview]
Message-ID: <27862556-7190-8a72-e102-4ed07db6f756@proxmox.com> (raw)
In-Reply-To: <20230727083759.19001-3-a.zeidler@proxmox.com>
Am 27.07.23 um 10:37 schrieb Alexander Zeidler:
> configuring pbs-entries-max can avoid failing backups due to a high
> amount of files in folders where a folder exclusion is not possible
>
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> Changes since v2:
> Apply Fiona's comments:
> * remove property from permission check since it's included in performance
> * vzdump: make property a sub property of performance
>
> Changes since v1:
> * add 'pbs-entries-max' according to the new shortened permission check
>
>
> configs/vzdump.conf | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/vzdump.conf b/configs/vzdump.conf
> index 2ea09ae0..954a4784 100644
> --- a/configs/vzdump.conf
> +++ b/configs/vzdump.conf
> @@ -16,3 +16,4 @@
> #exclude-path: PATHLIST
> #pigz: N
> #notes-template: {{guestname}}
> +#performance: pbs-entries-max=N
There already is a #performance: max-workers=N further up. You should
add it to that, because duplicate options won't be handled correctly AFAIK.
next prev parent reply other threads:[~2023-07-27 9:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 8:37 [pve-devel] [PATCH v3 manager/container/guest-common/docs 0/5] fix #3069: add pbs-entries-max to vzdump.conf Alexander Zeidler
2023-07-27 8:37 ` [pve-devel] [PATCH v3 manager/container/guest-common/docs 1/5] api: backup: refactor backup permission check Alexander Zeidler
2023-07-27 8:37 ` [pve-devel] [PATCH v3 manager 2/5] fix #3069: vzdump: add property 'performance: pbs-entries-max=N' Alexander Zeidler
2023-07-27 9:05 ` Fiona Ebner [this message]
2023-07-27 8:37 ` [pve-devel] [PATCH v3 container 3/5]: fix #3069: vzdump: add 'pbs-entries-max' parameter Alexander Zeidler
2023-07-27 9:22 ` Fiona Ebner
2023-07-27 8:37 ` [pve-devel] [PATCH v3 guest-common 4/5] fix #3069: vzdump: schema: add 'pbs-entries-max' property Alexander Zeidler
2023-07-27 9:32 ` Fiona Ebner
2023-07-27 8:37 ` [pve-devel] [PATCH v3 docs 5/5] vzdump: mention new parameter 'pbs-entries-max' Alexander Zeidler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27862556-7190-8a72-e102-4ed07db6f756@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox