From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
"t.lamprecht@proxmox.com" <t.lamprecht@proxmox.com>,
"aderumier@odiso.com" <aderumier@odiso.com>,
"f.ebner@proxmox.com" <f.ebner@proxmox.com>
Subject: Re: [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel
Date: Sun, 4 Jun 2023 06:29:42 +0000 [thread overview]
Message-ID: <27717f9d2f054a26c795f58359f3e72b90848924.camel@groupe-cyllene.com> (raw)
In-Reply-To: <f505012a-f64c-301c-4078-7295b5152d79@proxmox.com>
Le samedi 03 juin 2023 à 16:14 +0200, Thomas Lamprecht a écrit :
> Am 01/06/2023 um 11:06 schrieb DERUMIER, Alexandre:
> > > Maybe the easiest would be to extract the aes flag out of the
> > > grid
> > > into
> > > the non-advanced part?
> > >
> > Couldn't be easier to keep aes enable by default in a single model
> > (even if it's doesn't match the x86-64 spec). and allow user to
> > optin
> > disable it.
> > The only server where you need to disable aes if for nahelem, and I
> > don't think that a lot of users still have this cpu in production.
> > (so keeping the aes flag in advanced section make sense).
> > Also, user with really old servers, could keep to use kvm64 model,
> > where aes is not enabled.
>
>
> I also think that we should not bend to much for Nehalem, and fwiw if
> we go for a v2+aes CPU model (which IMO is one of the easies
> solutions)
> we would only need that for v2, as v3 could always have that enabled
> by
> default FWIWCT?
>
> So:
>
> x86-64-v2
> x86-64-v2-aes (UI default)
> x86-64-v3
>
> (and that as real models, not just UI fakery) would work,
>
That's exactly what I have done for the v4 patch series ;)
> But tbh., I'd not be completely against just enabling it for v2 and
> warning,
> or even erroring, if the VM gets created on a host that doesn't
> supports it
> (which might be a good idea for any vX level); as Alexandre is right,
> a lot of
> users needlessly get slower VMs that they could be and production
> setups with
> a 14 year old CPU are just very unlikely, and they simply can disable
> AES again...
>
I have see that with a lot of my customers, (and also with some
benchmark on the net), where admins don't even known what AES is ^_^
next prev parent reply other threads:[~2023-06-04 6:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 10:25 Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 1/7] cpuconfig: add new x86-64-vX models Alexandre Derumier
2023-05-31 11:08 ` Fiona Ebner
2023-05-31 15:08 ` DERUMIER, Alexandre
2023-06-01 9:17 ` Fiona Ebner
2023-06-01 11:27 ` DERUMIER, Alexandre
2023-05-22 10:25 ` [pve-devel] [PATCH v2 pve-manager 1/1] qemu: processor : set x86-64-v2 as default cputype for create wizard Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH pve-common 1/1] read_cpuinfo: add msr support Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 2/7] cpumodel: add cpu models with flags Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 3/7] cpumodel: compute qemu supported flags Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 4/7] cpuconfig: add get_host_cpu_flags Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 5/7] cpuconfig: add find_best_cpumodel Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 6/7] cpuconfig: add find_hosts_common_flags Alexandre Derumier
2023-05-22 10:25 ` [pve-devel] [PATCH v3 qemu-server 7/7] add best cpu model detection tests Alexandre Derumier
2023-05-31 11:36 ` [pve-devel] [PATCH-SERIES v3 qemu-server/manager/common] add and set x86-64-v2 as default model for new vms and detect best cpumodel Fiona Ebner
2023-05-31 14:34 ` DERUMIER, Alexandre
2023-06-01 8:34 ` Fiona Ebner
2023-06-01 9:06 ` DERUMIER, Alexandre
2023-06-03 14:14 ` Thomas Lamprecht
2023-06-04 6:29 ` DERUMIER, Alexandre [this message]
2023-06-03 14:05 ` Thomas Lamprecht
2023-06-01 9:34 ` Fiona Ebner
2023-06-01 11:37 ` DERUMIER, Alexandre
2023-06-01 13:53 ` DERUMIER, Alexandre
2023-06-01 15:56 ` Fiona Ebner
2023-06-01 21:15 ` DERUMIER, Alexandre
2023-06-02 7:28 ` Fiona Ebner
2023-06-02 9:13 ` DERUMIER, Alexandre
2023-06-02 11:13 ` Fiona Ebner
2023-06-02 11:44 ` DERUMIER, Alexandre
2023-06-03 14:21 ` Thomas Lamprecht
[not found] ` <8277a27b-a70f-b731-69f7-fc9ae69b2da2@binovo.es>
2023-06-01 16:00 ` Fiona Ebner
2023-06-02 12:41 ` Aaron Lauterer
2023-06-02 14:15 ` DERUMIER, Alexandre
2023-06-02 16:09 ` Aaron Lauterer
2023-06-02 16:27 ` DERUMIER, Alexandre
[not found] ` <fa3565e5-3a9c-9348-f291-554a0e0d6628@binovo.es>
2023-06-06 9:15 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27717f9d2f054a26c795f58359f3e72b90848924.camel@groupe-cyllene.com \
--to=alexandre.derumier@groupe-cyllene.com \
--cc=aderumier@odiso.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox