From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH v4 qemu] fix #1534: vma: Add extract filter for disk images
Date: Wed, 30 Aug 2023 09:16:26 +0200 [thread overview]
Message-ID: <275167d1-8ec8-1a64-f7b4-ddd8997e9fe6@proxmox.com> (raw)
In-Reply-To: <f381fd3f-2927-8001-f436-c80447a8960a@proxmox.com>
Am 29.08.23 um 14:10 schrieb Fiona Ebner:
> Am 09.08.23 um 16:08 schrieb Filip Schauer:
>> ++ size_t token_len = comma - token;
>> ++ if (token_len == devname_len && strncmp(token, di->devname, token_len) == 0) {
>
> Passing devname_len to strncmp would avoid the token_len variable.
>
Would need to be devname_len + 1, but since we want to compare the whole
string, especially once we got the null-terminated split tokens, we can
also just use strcmp().
prev parent reply other threads:[~2023-08-30 7:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 14:08 Filip Schauer
2023-08-29 12:10 ` Fiona Ebner
2023-08-30 7:16 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=275167d1-8ec8-1a64-f7b4-ddd8997e9fe6@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox