public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: "肖 宇良" <xyl1509410143@outlook.com>,
	"pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>
Subject: Re: [QUESTION] pve-storage: intended Datastore.Audit visibility of prunebackups metadata
Date: Tue, 3 Nov 2026 16:17:35 +0100	[thread overview]
Message-ID: <27370b52-b557-47f4-a5a4-fe65ca26831e@proxmox.com> (raw)
In-Reply-To: <ME5PR01MB1090955C9DB2349DE0AD2AE11BF6A2@ME5PR01MB10909.ausprd01.prod.outlook.com>

Hello Yuliang Xiao,

Am 03.11.26 um 1:28 PM schrieb 肖 宇良:
> The prunebackups API explicitly permits Datastore.Audit or Datastore.AllocateSpace and does not apply check_volume_access() to its result. The content API currently does apply that per-volume check.
> The original prunebackups API discussion introduced the Datastore.Audit/Datastore.AllocateSpace permission check together with the volid, ctime, mark and vmid response fields:
> https://lore.proxmox.com/pve-devel/ae57fdf5-c43a-f828-0d47-8e7aceb5ea62@proxmox.com/T/
> In January 2023 it was explained that Datastore.Audit alone only permits knowing about the storage, and that listing backup archives additionally requires the per-volume check: Datastore.AllocateSpace on the storage plus VM.Backup on the owning guest:
> https://lore.proxmox.com/pve-devel/1672907478.qzv3ze8grn.astroid@yuna.none/T/
> A July 2025 patch for bug #5492 proposed letting Datastore.Audit users list a restricted set of backup metadata for monitoring. The thread was still discussing which fields to retain, and the content API still applies check_volume_access() in Proxmox VE 9.2.21:
> https://lore.proxmox.com/pve-devel/1753881023.tvgbrwck0i.astroid@yuna.none/T/
> Could you clarify whether the current prunebackups behavior is intentional?
> 
>   *
> If yes, would it make sense to document that Datastore.Audit includes visibility of backup IDs and timestamps through the prune preview?
>   *
> If not, should the dry-run result apply the same per-volume filtering as the content API?
thank you for the question! Yes, applying the same filtering as the
content endpoint is sensible. I sent a patch to do so:
https://lore.proxmox.com/pve-devel/20261103151432.197799-1-f.ebner@proxmox.com/T/

Best Regards,
Fiona




      reply	other threads:[~2026-11-03 15:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-02  3:14 [QUESTION] pve-storage: intended Datastore.Audit visibility of prunebackups metadata 肖 宇良
2026-11-03 15:17 ` Fiona Ebner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27370b52-b557-47f4-a5a4-fe65ca26831e@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=xyl1509410143@outlook.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal