public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/3] api: ceph: add endpoint to fetch config keys
Date: Sat, 11 Mar 2023 18:07:05 +0100	[thread overview]
Message-ID: <26db04bc-ce75-5f9a-a85b-01b35b036cce@proxmox.com> (raw)
In-Reply-To: <0d08ee63-9f1e-2218-e8e7-358196d795c3@proxmox.com>

Am 08/03/2023 um 13:14 schrieb Dominik Csapak:
> high level:
> 
> as you mentioned the path 'configkey' is not really optimal
> 
> i recently mentioned off-list that we could clean this up on
> the next breaking major release with a breaking api change:
> 
> have a 'config' dir and a
> 'file'
> 'db'
> and 'key'( or 'value') api endpoint inside
> that represents the different things
> 
> for now a possible change could be to do it in 'config'
> but with a new parameter, though that's also not ideal
> 
> any further ideas/suggestions @Thomas?


We could add the full

cfg/
   raw
   db
   value

now already, re-mount the 'cfg/raw' one on the current 'config' (or just keep
the code duplicated, not much gain if we remove it anyway) one and then drop that
old 'config' one in PVE 8.0; slightly hacky but IMO not that much.

Might want to check what other uses of config, cfg, conf, configuration there are
in API path's though, as ideally we keep the total unique count of them the same ;-)




  reply	other threads:[~2023-03-11 17:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-13 15:09 [pve-devel] [PATCH manager 0/3] fix 2515 use default sizes for new ceph Aaron Lauterer
2023-01-13 15:09 ` [pve-devel] [PATCH manager 1/3] api: ceph: add endpoint to fetch config keys Aaron Lauterer
2023-03-08 12:14   ` Dominik Csapak
2023-03-11 17:07     ` Thomas Lamprecht [this message]
2023-03-13 12:58       ` Aaron Lauterer
2023-03-13 16:31         ` Thomas Lamprecht
2023-01-13 15:09 ` [pve-devel] [PATCH manager 2/3] fix #2515: ui: ceph pool create: use configured defaults for size and min_size Aaron Lauterer
2023-03-08 12:14   ` Dominik Csapak
2023-01-13 15:09 ` [pve-devel] [PATCH manager 3/3] ui: ceph pool edit: rework with controller and formulas Aaron Lauterer
2023-03-08 12:15   ` Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26db04bc-ce75-5f9a-a85b-01b35b036cce@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=a.lauterer@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal