* [pve-devel] [PATCH/RFC manager] pveceph: also install nvme-cli
@ 2021-07-05 9:50 Fabian Ebner
2021-07-05 10:05 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-07-05 9:50 UTC (permalink / raw)
To: pve-devel
The nvme-cli package is recommended by (our) Ceph packages, but here
--no-install-recommends is used to avoid pulling in too much.
The issue with not installing nvme-cli is that a "security
information" mail notification is triggered by sudo each time Ceph
tries to get the device health metrics. While there is a sudoers
rule for /usr/sbin/nvme, Ceph uses 'sudo nvme ...', so it does not
apply when the package is not installed.
This didn't seem to happen with sudo in buster.
It's about 1 MiB of additional packages (nvme-cli + uuid-runtime).
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
An alternative would be to patch Ceph to use the full /usr/sbin/nvme
for its call (not tested).
PVE/CLI/pveceph.pm | 1 +
1 file changed, 1 insertion(+)
diff --git a/PVE/CLI/pveceph.pm b/PVE/CLI/pveceph.pm
index f23a996d..356af282 100755
--- a/PVE/CLI/pveceph.pm
+++ b/PVE/CLI/pveceph.pm
@@ -173,6 +173,7 @@ __PACKAGE__->register_method ({
ceph-mds
ceph-fuse
gdisk
+ nvme-cli
);
print "start installation\n";
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH/RFC manager] pveceph: also install nvme-cli
2021-07-05 9:50 [pve-devel] [PATCH/RFC manager] pveceph: also install nvme-cli Fabian Ebner
@ 2021-07-05 10:05 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-07-05 10:05 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 05.07.21 11:50, Fabian Ebner wrote:
> The nvme-cli package is recommended by (our) Ceph packages, but here
> --no-install-recommends is used to avoid pulling in too much.
>
> The issue with not installing nvme-cli is that a "security
> information" mail notification is triggered by sudo each time Ceph
> tries to get the device health metrics. While there is a sudoers
> rule for /usr/sbin/nvme, Ceph uses 'sudo nvme ...', so it does not
> apply when the package is not installed.
>
> This didn't seem to happen with sudo in buster.
>
> It's about 1 MiB of additional packages (nvme-cli + uuid-runtime).
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
>
> An alternative would be to patch Ceph to use the full /usr/sbin/nvme
> for its call (not tested).
>
> PVE/CLI/pveceph.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-05 10:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-05 9:50 [pve-devel] [PATCH/RFC manager] pveceph: also install nvme-cli Fabian Ebner
2021-07-05 10:05 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox