[pve-devel] [PATCH widget-toolkit] TaskProgress: show text instead of percentage

[pve-devel] [PATCH widget-toolkit] TaskProgress: show text instead of percentage

[Aaron Lauterer]

The text needs to be defined in the wait() call as otherwise the
Ext.Progressbar will show a percentage that is not correct anyway but
just reflects where the animated progress bar itself is.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
---
This wasn't much of a problem in most cases where the task finished very
fast. It was most notable in the "Move Disk" situation where the task
could take a very long time, but we switch over to the detailed task log
view there anyway.

I am not sure if showing 'running..." did work at some point in the
past, but now it definitely needs to be defined when calling pbar.wait()

 src/window/TaskViewer.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/window/TaskViewer.js b/src/window/TaskViewer.js
index 9293d95..5d8bb84 100644
--- a/src/window/TaskViewer.js
+++ b/src/window/TaskViewer.js
@@ -37,7 +37,7 @@ Ext.define('Proxmox.window.TaskProgress', {
 	    return defaultValue;
 	};
 
-	let pbar = Ext.create('Ext.ProgressBar', { text: 'running...' });
+	let pbar = Ext.create('Ext.ProgressBar');
 
 	me.mon(statstore, 'load', function() {
 	    let status = getObjectValue('status');
@@ -79,7 +79,7 @@ Ext.define('Proxmox.window.TaskProgress', {
 
 	statstore.startUpdate();
 
-	pbar.wait();
+	pbar.wait({ text: gettext('running...') });
     },
 });
 
-- 
2.30.2

Re: [pve-devel] [PATCH widget-toolkit] TaskProgress: show text instead of percentage

[Aaron Lauterer]

ping

Recently ran into a situation where, on a slower system, the 100% were reached, 
and it started again at 0%.

On 7/22/22 14:15, Aaron Lauterer wrote:
> The text needs to be defined in the wait() call as otherwise the
> Ext.Progressbar will show a percentage that is not correct anyway but
> just reflects where the animated progress bar itself is.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> This wasn't much of a problem in most cases where the task finished very
> fast. It was most notable in the "Move Disk" situation where the task
> could take a very long time, but we switch over to the detailed task log
> view there anyway.
> 
> I am not sure if showing 'running..." did work at some point in the
> past, but now it definitely needs to be defined when calling pbar.wait()
> 
>   src/window/TaskViewer.js | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/window/TaskViewer.js b/src/window/TaskViewer.js
> index 9293d95..5d8bb84 100644
> --- a/src/window/TaskViewer.js
> +++ b/src/window/TaskViewer.js
> @@ -37,7 +37,7 @@ Ext.define('Proxmox.window.TaskProgress', {
>   	    return defaultValue;
>   	};
>   
> -	let pbar = Ext.create('Ext.ProgressBar', { text: 'running...' });
> +	let pbar = Ext.create('Ext.ProgressBar');
>   
>   	me.mon(statstore, 'load', function() {
>   	    let status = getObjectValue('status');
> @@ -79,7 +79,7 @@ Ext.define('Proxmox.window.TaskProgress', {
>   
>   	statstore.startUpdate();
>   
> -	pbar.wait();
> +	pbar.wait({ text: gettext('running...') });
>       },
>   });
>   

[pve-devel] applied: [PATCH widget-toolkit] TaskProgress: show text instead of percentage

[Thomas Lamprecht]

Am 22/07/2022 um 14:15 schrieb Aaron Lauterer:
> The text needs to be defined in the wait() call as otherwise the
> Ext.Progressbar will show a percentage that is not correct anyway but
> just reflects where the animated progress bar itself is.
> 
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> This wasn't much of a problem in most cases where the task finished very
> fast. It was most notable in the "Move Disk" situation where the task
> could take a very long time, but we switch over to the detailed task log
> view there anyway.
> 
> I am not sure if showing 'running..." did work at some point in the
> past, but now it definitely needs to be defined when calling pbar.wait()
> 
>  src/window/TaskViewer.js | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
>

applied, thanks!