Re: [pve-devel] [PATCH manager 3/3] ui: wizards: allow adding tags in the qemu/lxc create wizard

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 19/10/2023 um 15:36 schrieb Dominik Csapak:
> in the general tab in the advanced section.
> 
> For that to work, we introduce a new option for the TagEditContainer
> named 'editOnly', which controls now the cancel/finish buttons,
> automatically enter edit mode and disable enter/escape keypresses.
> 
> We also prevent now the loading of tags while in edit mode, so the tags
> don't change while editing (this can be jarring and unexpected).
> 
> In the wizard, we override the layout such that the tags wrap when there
> are too many, and make the field scrollable and set a height, so that
> the user can enter as many tags as he wants without having the field
> overflow or cut off.
> 
> To properly align the input with the '+' button, we have to add a custom
> css class there. (In the hbox we could set the alignment, but this is
> not possible in the 'column' layout)
> 

I'd wrap this in a fieldset with Tags as legend (well, still "title" in
ExtJS), ideally in its own small PVE.form.TagEditFieldSet module, that
extends the Ext.form.FieldSet class? That could then also contain
the getValue handling, further reducing the wizard specific changes.

Allowing the height to grow until a max-height (i.e., fills out wizard
panel) and only then get scrollable would be still nice though.