From: Fiona Ebner <f.ebner@proxmox.com>
To: Maximiliano Sandoval <m.sandoval@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ceph: pool edit: set target ratio to 0 when the value is unset
Date: Wed, 6 Mar 2024 16:38:33 +0100 [thread overview]
Message-ID: <25b1183e-c156-4632-83e9-836766d23a4e@proxmox.com> (raw)
In-Reply-To: <s8owmqffkzz.fsf@proxmox.com>
Am 06.03.24 um 16:17 schrieb Maximiliano Sandoval:
> Fiona Ebner <f.ebner@proxmox.com> writes:
>
>> It might be cleaner to just use
>> emptyValue: 0,
>> in the field declaration like is already done for the "Target Size"
>> field. And the same issue is also present for the "Min. # of PGs" field,
>> right?
>
> Thanks for the emptyValue tip, I didn't know about it. Unfortunately, I
> tested this and it didn't work.
>
Yes, sorry. Unfortunately, that is a feature specific to
PVE.form.SizeField, respectively Proxmox.form.SizeField.
For the "Min. # of PGs" field, we could add a similar feature to
proxmoxintegerfield. And the "Target Ratio" field is just a numberfield,
so would need yet another instance of the feature. So maybe not worth it.
prev parent reply other threads:[~2024-03-06 15:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-06 14:14 Maximiliano Sandoval
2024-03-06 15:08 ` Fiona Ebner
2024-03-06 15:17 ` Maximiliano Sandoval
2024-03-06 15:38 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25b1183e-c156-4632-83e9-836766d23a4e@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox