From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Filip Schauer <f.schauer@proxmox.com>
Subject: Re: [pve-devel] [PATCH container/manager v2 0/2] add deny read/write options for device passthrough
Date: Fri, 6 Sep 2024 14:14:27 +0200 [thread overview]
Message-ID: <2568be20-ad08-4539-b98f-9b9d454634ab@proxmox.com> (raw)
In-Reply-To: <20240724171857.432913-1-f.schauer@proxmox.com>
Am 24.07.24 um 19:18 schrieb Filip Schauer:
> Add the deny_read and deny_write options for device passthrough, to
> restrict container access to devices.
>
> This allows for passing through a device in read-only mode without
> giving the container full access it.
>
> Up until now a container with a device passed through to it was granted
> full access to that device without an option to restrict that access as
> pointed out by @Fiona.
>
> Changes since v1:
> * set default values for deny_read & deny_write
> * remove the deny_read checkbox from the UI, since it is expected to
> only have a very niche use case.
>
We could also use dashes instead of underscores, i.e.
"deny-read"/"deny-write" as we often do for new properties.
Still not fully sure we need deny_read in the backend until somebody
complains with a sensible use case, but I guess it doesn't hurt if it's
already there.
In any case:
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Tested-by: Fiona Ebner <f.ebner@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-09-06 12:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-24 17:18 Filip Schauer
2024-07-24 17:18 ` [pve-devel] [PATCH container v2 1/2] " Filip Schauer
2024-07-24 17:18 ` [pve-devel] [PATCH manager v2 2/2] ui: lxc: add readonly option " Filip Schauer
2024-09-06 12:14 ` Fiona Ebner [this message]
2024-09-06 17:01 ` [pve-devel] [PATCH container/manager v2 0/2] add deny read/write options " Thomas Lamprecht
2024-09-09 12:52 ` Filip Schauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2568be20-ad08-4539-b98f-9b9d454634ab@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.schauer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox