From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] api: replication: don't send mails about failed replication only once
Date: Wed, 27 Apr 2022 10:30:42 +0200 [thread overview]
Message-ID: <2541d2ed-5774-76af-b722-bd5c08d06b31@proxmox.com> (raw)
In-Reply-To: <20220422121548.69146-1-f.ebner@proxmox.com>
On 22.04.22 14:15, Fabian Ebner wrote:
> but rather multiple times becoming exponentially less frequent.
>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/API2/Replication.pm | 15 ++++++++++++++-
> 1 file changed, 14 insertions(+), 1 deletion(-)
>
>
applied, thanks!
Added a follow up to always mail the first three tries to notice the admin that the
problem wasn't just a fluke.
I'm now also including some relevant info in the mail, like schedule, last successful
sync and next sync try, the actual fail count so that an admin can tell how often it
was tried (as the mail frequency doesn't matches that) and a note about reducing
notification frequency at $fail_count == 3, to avoid confusion.
prev parent reply other threads:[~2022-04-27 8:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 12:15 [pve-devel] " Fabian Ebner
2022-04-27 8:30 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2541d2ed-5774-76af-b722-bd5c08d06b31@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox