public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text
@ 2023-01-20 11:17 Lukas Wagner
  2023-01-20 11:17 ` [pve-devel] [PATCH manager 1/2] ui: backup: replication: replace non-clickable checkbox " Lukas Wagner
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Lukas Wagner @ 2023-01-20 11:17 UTC (permalink / raw)
  To: pve-devel

Consider this an RFC to maybe spark up a discussion about this. 

In our UI, we've been a bit inconsistent with the use of checkboxes/text
for `enabled` properties in table views. Looking through the UI, I've
found that the following UI elements use a checkbox UI control to
indicate wheter something is enabled or not:

 * backup job overview
 * APT repository overview
 * replication job overview

While looking sleek, the problem with this is that from a user's
perspective, a checkbox generally implies that it is operable by
clicking on it (which we allow in other places, to make the matter even
more confusing). Now, for the three UI elements mentioned above, I would 
say it is a good thing that they are not manipulateable from the overview,
in order to avoid any accidental modifications.

My suggestion would be, and this is what I've included in this patch
series, to replace those checkboxes with Yes/No text. This is the way
how it is done in many other places of the system.

If we want something prettier, we could replace/augment the text with some
fa-icon, e.g. a check-mark or an X - the important part is that they are
visually distinct from ExtJS's checkboxes.

Note: Firewall configuration also uses a checkbox, however there it is
possible to enable/disable elements by clicking on the checkbox - so
this can stay as IMHO.

pve-manager:

Lukas Wagner (1):
  ui: backup: replication: replace non-clickable checkbox with Yes/No
    text

 www/manager6/dc/Backup.js        | 7 ++-----
 www/manager6/grid/Replication.js | 8 ++++----
 2 files changed, 6 insertions(+), 9 deletions(-)

proxmox-widget-toolkit:

Lukas Wagner (1):
  repo view: replace non-clickable checkbox with Yes/No text

 src/node/APTRepositories.js | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

-- 
2.30.2





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-01-23 11:02 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-20 11:17 [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with Yes/No text Lukas Wagner
2023-01-20 11:17 ` [pve-devel] [PATCH manager 1/2] ui: backup: replication: replace non-clickable checkbox " Lukas Wagner
2023-01-20 11:17 ` [pve-devel] [PATCH widget-toolkit 2/2] repo view: " Lukas Wagner
2023-01-20 14:09 ` [pve-devel] [PATCH manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes " Thomas Lamprecht
2023-01-23 10:46   ` Lukas Wagner
2023-01-23 10:57     ` Thomas Lamprecht
2023-01-23 11:01       ` Lukas Wagner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal