* [pve-devel] [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema
@ 2024-10-04 8:34 Fabian Grünbichler
2024-10-04 14:26 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Grünbichler @ 2024-10-04 8:34 UTC (permalink / raw)
To: pve-devel
using the definition already used in the task index API schema in the same
module.
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
---
starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is
the return schema it doesn't really matter I guess, but might be worth it to
settle on one or the other for all 4 instances of pstart/starttime here?
PVE/API2/Tasks.pm | 3 +++
1 file changed, 3 insertions(+)
diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
index b763b74d8..4ea9832b8 100644
--- a/PVE/API2/Tasks.pm
+++ b/PVE/API2/Tasks.pm
@@ -482,6 +482,9 @@ __PACKAGE__->register_method({
starttime => {
type => 'number',
},
+ pstart => {
+ type => 'integer',
+ },
node => {
type => 'string',
},
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema
2024-10-04 8:34 [pve-devel] [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema Fabian Grünbichler
@ 2024-10-04 14:26 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-10-04 14:26 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Grünbichler
On 04/10/2024 10:34, Fabian Grünbichler wrote:
> using the definition already used in the task index API schema in the same
> module.
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is
> the return schema it doesn't really matter I guess, but might be worth it to
> settle on one or the other for all 4 instances of pstart/starttime here?
yeah, that would be nice. Using integer, like you did, might be the best
option for non-fractional UNIX seconds I think.
>
> PVE/API2/Tasks.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-10-04 14:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-10-04 8:34 [pve-devel] [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema Fabian Grünbichler
2024-10-04 14:26 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox