public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] fix #5753: api: add 'pstart' member to task status return schema
Date: Fri, 4 Oct 2024 16:26:14 +0200	[thread overview]
Message-ID: <24835825-ca7a-4fb4-b796-ab402fb9b55f@proxmox.com> (raw)
In-Reply-To: <20241004083446.408306-1-f.gruenbichler@proxmox.com>

On 04/10/2024 10:34, Fabian Grünbichler wrote:
> using the definition already used in the task index API schema in the same
> module.
> 
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
> starttime has a disagreeing schema atm - 'number' vs 'integer'. since this is
> the return schema it doesn't really matter I guess, but might be worth it to
> settle on one or the other for all 4 instances of pstart/starttime here?

yeah, that would be nice. Using integer, like you did, might be the best
option for non-fractional UNIX seconds I think. 

> 
>  PVE/API2/Tasks.pm | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

applied, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      reply	other threads:[~2024-10-04 14:26 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-04  8:34 [pve-devel] " Fabian Grünbichler
2024-10-04 14:26 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24835825-ca7a-4fb4-b796-ab402fb9b55f@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal