Re: [pve-devel] [PATCH manager v7 01/14] api: /cluster/resources: add tags to returned properties

[Aaron Lauterer <a.lauterer@proxmox.com>]

one small nit inside

On 6/21/22 11:19, Dominik Csapak wrote:
> by querying 'lock' and 'tags' with 'get_guest_config_properties'
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   PVE/API2/Cluster.pm | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
> index 525a95a1..c1e96bd7 100644
> --- a/PVE/API2/Cluster.pm
> +++ b/PVE/API2/Cluster.pm
> @@ -360,7 +360,8 @@ __PACKAGE__->register_method({
>   
>   	# we try to generate 'numbers' by using "$X + 0"
>   	if (!$param->{type} || $param->{type} eq 'vm') {
> -	    my $locked_vms = PVE::Cluster::get_guest_config_property('lock');
> +	    my $prop_list = [qw(lock tags)];
> +	    my $props = PVE::Cluster::get_guest_config_properties($prop_list);
>   
>   	    for my $vmid (sort keys %$idlist) {
>   
> @@ -392,8 +393,10 @@ __PACKAGE__->register_method({
>   		# only skip now to next to ensure that the pool stats above are filled, if eligible
>   		next if !$rpcenv->check($authuser, "/vms/$vmid", [ 'VM.Audit' ], 1);
>   
> -		if (defined(my $lock = $locked_vms->{$vmid}->{lock})) {
> -		    $entry->{lock} = $lock;
> +		for my $prop (@$prop_list) {

consider @{$prop_list} instead of @$prop_list.

> +		    if (defined(my $value = $props->{$vmid}->{$prop})) {
> +			$entry->{$prop} = $value;
> +		    }
>   		}
>   
>   		if (defined($entry->{pool}) &&