public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method
@ 2023-03-24  9:02 Friedrich Weber
  2023-03-24  9:16 ` Dominik Csapak
  2023-03-26 15:58 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Friedrich Weber @ 2023-03-24  9:02 UTC (permalink / raw)
  To: pve-devel

A previous commit (51083ee) added an override of the internal ExtJS
method `Ext.data.Store.onProxyLoad` in order to fix a race condition.
This override calls `Operation.getProxy`. However, this method is not
available on Sencha Touch. As a consequence, the mobile UI was broken.

This commit modifies the override such that it has no effect in the
mobile UI.

Fixes: 51083ee54aa98af5a711622e4ed240840dcbbabe
Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
---
 src/Utils.js | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/Utils.js b/src/Utils.js
index 7b7a83a..3200884 100644
--- a/src/Utils.js
+++ b/src/Utils.js
@@ -1483,10 +1483,11 @@ Ext.override(Ext.data.Store, {
     // If the store's proxy is changed while it is waiting for an AJAX
     // response, `onProxyLoad` will still be called for the outdated response.
     // To avoid displaying inconsistent information, only process responses
-    // belonging to the current proxy.
+    // belonging to the current proxy. However, do not apply this workaround
+    // to the mobile UI, as Sencha Touch has an incompatible internal API.
     onProxyLoad: function(operation) {
 	let me = this;
-	if (operation.getProxy() === me.getProxy()) {
+	if (Proxmox.Utils.toolkit === 'touch' || operation.getProxy() === me.getProxy()) {
 	    me.callParent(arguments);
 	} else {
 	    console.log(`ignored outdated response: ${operation.getRequest().getUrl()}`);
-- 
2.30.2





^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method
  2023-03-24  9:02 [pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method Friedrich Weber
@ 2023-03-24  9:16 ` Dominik Csapak
  2023-03-26 15:58 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Dominik Csapak @ 2023-03-24  9:16 UTC (permalink / raw)
  To: Proxmox VE development discussion, Friedrich Weber

works, LGTM

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>




^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method
  2023-03-24  9:02 [pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method Friedrich Weber
  2023-03-24  9:16 ` Dominik Csapak
@ 2023-03-26 15:58 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2023-03-26 15:58 UTC (permalink / raw)
  To: Proxmox VE development discussion, Friedrich Weber

Am 24/03/2023 um 10:02 schrieb Friedrich Weber:
> A previous commit (51083ee) added an override of the internal ExtJS
> method `Ext.data.Store.onProxyLoad` in order to fix a race condition.
> This override calls `Operation.getProxy`. However, this method is not
> available on Sencha Touch. As a consequence, the mobile UI was broken.
> 
> This commit modifies the override such that it has no effect in the
> mobile UI.
> 
> Fixes: 51083ee54aa98af5a711622e4ed240840dcbbabe
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
>  src/Utils.js | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
>

applied, thanks!




^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-03-26 15:58 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-24  9:02 [pve-devel] [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method Friedrich Weber
2023-03-24  9:16 ` Dominik Csapak
2023-03-26 15:58 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal