From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] fix #4612: mobile: avoid crash due to missing getProxy method
Date: Sun, 26 Mar 2023 17:58:28 +0200 [thread overview]
Message-ID: <2471ee05-2702-3b2f-7d7c-650d3ac0dc05@proxmox.com> (raw)
In-Reply-To: <20230324090230.33803-1-f.weber@proxmox.com>
Am 24/03/2023 um 10:02 schrieb Friedrich Weber:
> A previous commit (51083ee) added an override of the internal ExtJS
> method `Ext.data.Store.onProxyLoad` in order to fix a race condition.
> This override calls `Operation.getProxy`. However, this method is not
> available on Sencha Touch. As a consequence, the mobile UI was broken.
>
> This commit modifies the override such that it has no effect in the
> mobile UI.
>
> Fixes: 51083ee54aa98af5a711622e4ed240840dcbbabe
> Suggested-by: Dominik Csapak <d.csapak@proxmox.com>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> src/Utils.js | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-03-26 15:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 9:02 [pve-devel] " Friedrich Weber
2023-03-24 9:16 ` Dominik Csapak
2023-03-26 15:58 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2471ee05-2702-3b2f-7d7c-650d3ac0dc05@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox