* [pve-devel] [PATCH manager] ui: BackupEdit: fix reset tracking
@ 2022-11-15 13:23 Dominik Csapak
2022-11-15 13:32 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2022-11-15 13:23 UTC (permalink / raw)
To: pve-devel
when the mode changes, we set the pool selector visible/hidden, but
we never disabled/enabled it. this tripped up the dirty state of the
form always showing the reset button as enabled.
to fix it, properly enable/disable it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/dc/Backup.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/dc/Backup.js b/www/manager6/dc/Backup.js
index c81a76cea..4638cbb68 100644
--- a/www/manager6/dc/Backup.js
+++ b/www/manager6/dc/Backup.js
@@ -322,10 +322,12 @@ Ext.define('PVE.dc.BackupEdit', {
vmgrid.setDisabled(true);
vmidField.setValue('');
selPool.setVisible(true);
+ selPool.setDisabled(false);
selPool.allowBlank = false;
selectPoolMembers(selPool.value);
} else {
selPool.setVisible(false);
+ selPool.setDisabled(true);
selPool.allowBlank = true;
}
let list = vmidField.getValue();
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread* [pve-devel] applied: [PATCH manager] ui: BackupEdit: fix reset tracking
2022-11-15 13:23 [pve-devel] [PATCH manager] ui: BackupEdit: fix reset tracking Dominik Csapak
@ 2022-11-15 13:32 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2022-11-15 13:32 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 15/11/2022 um 14:23 schrieb Dominik Csapak:
> when the mode changes, we set the pool selector visible/hidden, but
> we never disabled/enabled it. this tripped up the dirty state of the
> form always showing the reset button as enabled.
>
> to fix it, properly enable/disable it
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/dc/Backup.js | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks! I adapted the subject to avoid the verbatim module name and
use a rather tag like style to: "ui: backup job edit: fix form reset tracking"
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-15 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-15 13:23 [pve-devel] [PATCH manager] ui: BackupEdit: fix reset tracking Dominik Csapak
2022-11-15 13:32 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox