* [pve-devel] [PATCH manager v2] ui: resource tree: show nodes/storages in tag view
@ 2024-11-15 14:08 Dominik Csapak
2024-11-15 14:57 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2024-11-15 14:08 UTC (permalink / raw)
To: pve-devel
this makes now use of the new sorting order since now we have
nodes, storages, and guests on one level in the tag view
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this replaces my previous patch:
ui: resource tree: show nodes/storages in pool/tag view by default
changes from that v1:
* don't show the storages/nodes in the pool view for now
* don't make it configurable, we can do that later too if people don't
want to see it
www/manager6/form/ViewSelector.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/www/manager6/form/ViewSelector.js b/www/manager6/form/ViewSelector.js
index f5de5c8e..6275b17b 100644
--- a/www/manager6/form/ViewSelector.js
+++ b/www/manager6/form/ViewSelector.js
@@ -35,7 +35,7 @@ Ext.define('PVE.form.ViewSelector', {
tags: {
text: gettext('Tag View'),
groups: ['tag'],
- getFilterFn: () => ({ data }) => data.type === 'qemu' || data.type === 'lxc',
+ getFilterFn: () => ({ data }) => ['qemu', 'lxc', 'node', 'storage'].indexOf(data.type) !== -1,
groupRenderer: function(info) {
let tag = PVE.Utils.renderTags(info.tag, PVE.UIOptions.tagOverrides);
return `<span class="proxmox-tags-full">${tag}</span>`;
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager v2] ui: resource tree: show nodes/storages in tag view
2024-11-15 14:08 [pve-devel] [PATCH manager v2] ui: resource tree: show nodes/storages in tag view Dominik Csapak
@ 2024-11-15 14:57 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2024-11-15 14:57 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 15.11.24 um 15:08 schrieb Dominik Csapak:
> this makes now use of the new sorting order since now we have
> nodes, storages, and guests on one level in the tag view
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this replaces my previous patch:
> ui: resource tree: show nodes/storages in pool/tag view by default
>
> changes from that v1:
> * don't show the storages/nodes in the pool view for now
> * don't make it configurable, we can do that later too if people don't
> want to see it
>
> www/manager6/form/ViewSelector.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-11-15 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-15 14:08 [pve-devel] [PATCH manager v2] ui: resource tree: show nodes/storages in tag view Dominik Csapak
2024-11-15 14:57 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox