Re: [pve-devel] [PATCH container] fix regression breaking container restore from PBS

[Filip Schauer <f.schauer@proxmox.com>]

On 17/11/2025 12:31, Filip Schauer wrote:
> This fixes a regression caused by an abs_filesystem_path call introduced
> with OCI image support. When trying to restore a container from a
> Proxmox Backup Server, this tried to resolve a path on a PBS datastore
> as a local file system path. This is fixed by only calling
> abs_filesystem_path on path-based storages.
>
> Fixes: 2aed26d320ae ("add support for OCI images as container
> templates")
>
> Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
> ---
>   src/PVE/API2/LXC.pm | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/PVE/API2/LXC.pm b/src/PVE/API2/LXC.pm
> index cffa17a..f74f19d 100644
> --- a/src/PVE/API2/LXC.pm
> +++ b/src/PVE/API2/LXC.pm
> @@ -544,7 +544,7 @@ __PACKAGE__->register_method({
>                       my $rootdir = PVE::LXC::mount_all($vmid, $storage_cfg, $conf, 1);
>                       my $archivepath = '-';
>                       $archivepath = PVE::Storage::abs_filesystem_path($storage_cfg, $archive)
> -                        if ($archive ne '-');
> +                        if ($archive ne '-' && $storage_cfg->{path});
>                       $bwlimit = PVE::Storage::get_bandwidth_limit(
>                           'restore', [keys %used_storages], $bwlimit,
>                       );

Unfortunatelly I only just noticed that this seems to break OCI images 
for me.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel