* [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms
@ 2025-04-10 8:08 Dominik Csapak
2025-04-10 8:10 ` Fiona Ebner
0 siblings, 1 reply; 4+ messages in thread
From: Dominik Csapak @ 2025-04-10 8:08 UTC (permalink / raw)
To: pve-devel
the help tooltip says it's unavailable for vms, and choosing a mode
here does not make a difference, so disable it for vms
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
www/manager6/window/Backup.js | 2 ++
1 file changed, 2 insertions(+)
diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js
index cb09c7b9..21cfe246 100644
--- a/www/manager6/window/Backup.js
+++ b/www/manager6/window/Backup.js
@@ -126,6 +126,8 @@ Ext.define('PVE.window.Backup', {
if (me.vmtype === 'lxc') {
pbsChangeDetectionModeSelector.setValue('__default__');
pbsChangeDetectionModeSelector.setDisabled(false);
+ } else {
+ pbsChangeDetectionModeSelector.setDisabled(true);
}
} else {
if (!compressionSelector.getEditable()) {
--
2.39.5
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms
2025-04-10 8:08 [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms Dominik Csapak
@ 2025-04-10 8:10 ` Fiona Ebner
2025-04-10 8:11 ` Dominik Csapak
0 siblings, 1 reply; 4+ messages in thread
From: Fiona Ebner @ 2025-04-10 8:10 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak
Am 10.04.25 um 10:08 schrieb Dominik Csapak:
> the help tooltip says it's unavailable for vms, and choosing a mode
> here does not make a difference, so disable it for vms
Maybe we should even hide it completely? It's just
distracting/additional mental load for no reason if it can't ever be
used for a VM.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms
2025-04-10 8:10 ` Fiona Ebner
@ 2025-04-10 8:11 ` Dominik Csapak
2025-04-10 8:13 ` Thomas Lamprecht
0 siblings, 1 reply; 4+ messages in thread
From: Dominik Csapak @ 2025-04-10 8:11 UTC (permalink / raw)
To: Fiona Ebner, Proxmox VE development discussion
On 4/10/25 10:10, Fiona Ebner wrote:
> Am 10.04.25 um 10:08 schrieb Dominik Csapak:
>> the help tooltip says it's unavailable for vms, and choosing a mode
>> here does not make a difference, so disable it for vms
>
> Maybe we should even hide it completely? It's just
> distracting/additional mental load for no reason if it can't ever be
> used for a VM.
yes also though about that, but ultimately decided against it, since
the help tooltip explains it anyway
if you want i can send a v2 to hide it when it's not available
(so no pbs or vm)
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms
2025-04-10 8:11 ` Dominik Csapak
@ 2025-04-10 8:13 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2025-04-10 8:13 UTC (permalink / raw)
To: Proxmox VE development discussion, Dominik Csapak, Fiona Ebner
Am 10.04.25 um 10:11 schrieb Dominik Csapak:
> On 4/10/25 10:10, Fiona Ebner wrote:
>> Am 10.04.25 um 10:08 schrieb Dominik Csapak:
>>> the help tooltip says it's unavailable for vms, and choosing a mode
>>> here does not make a difference, so disable it for vms
>>
>> Maybe we should even hide it completely? It's just
>> distracting/additional mental load for no reason if it can't ever be
>> used for a VM.
>
> yes also though about that, but ultimately decided against it, since
> the help tooltip explains it anyway
>
> if you want i can send a v2 to hide it when it's not available
> (so no pbs or vm)
Yes, lets please hide this.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-04-10 8:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-10 8:08 [pve-devel] [PATCH manager] ui: backup: disable change mode detection for vms Dominik Csapak
2025-04-10 8:10 ` Fiona Ebner
2025-04-10 8:11 ` Dominik Csapak
2025-04-10 8:13 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal