From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] ui: util: simplify volume_is_qemu_backup again
Date: Thu, 10 Apr 2025 10:35:05 +0200 [thread overview]
Message-ID: <22b13b00-eb64-4b2c-a642-78616fa3936e@proxmox.com> (raw)
In-Reply-To: <6e6228f1-378b-4fd4-a806-561caad2464c@proxmox.com>
Am 10.04.25 um 10:29 schrieb Fiona Ebner:
> Agreed and I get your point. It just felt more natural to go with the
> object approach since all call sites have that very object and would
> need to do the very same deconstruction if going with function(volume,
> format, subtype). Independent of the chosen approach, keeping it
> consistent with the volume_is_lxc_backup() helper is also an advantage.
Hmm, that one could be reworked too to a simpler/clearer signature.
Such methods in Utils are far from ideal in the first place, having
just an opaque signature does not really help here.
But yeah, does not really matter, one can hold it rather easily wrong
either way.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-10 8:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-10 7:16 Fiona Ebner
[not found] ` <61890f96-5720-4122-be8c-683adebc9f2c@proxmox.com>
2025-04-10 8:29 ` Fiona Ebner
2025-04-10 8:35 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=22b13b00-eb64-4b2c-a642-78616fa3936e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal