public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images
Date: Wed, 9 Apr 2025 09:10:12 +0200	[thread overview]
Message-ID: <22a457f5-12ce-48f3-9dfa-d4ae90715670@proxmox.com> (raw)
In-Reply-To: <a05bdfdc-dac0-4b8d-9d23-5913ca768c36@proxmox.com>

On 4/8/25 17:34, Thomas Lamprecht wrote:
> Am 08.04.25 um 14:13 schrieb Dominik Csapak:
>> By enabling the import button for qcow2/vmdk/raw files, and showing a
>> window with a VMID selector and the disk edit panel.
>>
> functionality wise I'd have applied that as it would be new and have thus
> almost no regression potential, might be also better to factor out the
> panel upfront in a dedicated commit and then integrate it everywhere.
> 
> But lets wait this out, no point in rushing things here.

Sure, don't rush this. Is there anything concrete you'd want to do have done differently
here though?

Even for the import storage content I'd really like to reuse the general disk edit panel
(for e.g. the detection of which bus/controller is used, etc.), so the regression potential
would be no different even if we'd only show it in the storage content.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-04-09  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-08 12:13 [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI Dominik Csapak
2025-04-08 12:13 ` [pve-devel] [PATCH manager v7 1/3] ui: qemu hd edit: allow importing a disk from the import storage Dominik Csapak
2025-04-08 12:13 ` [pve-devel] [PATCH manager v7 2/3] ui: vm create wizard: allow importing disks Dominik Csapak
2025-04-08 12:13 ` [pve-devel] [PATCH manager v7 3/3] ui: import storage content: allow importing of vm disk images Dominik Csapak
2025-04-08 15:34   ` Thomas Lamprecht
2025-04-09  7:10     ` Dominik Csapak [this message]
2025-04-10 11:39       ` Gilberto Ferreira via pve-devel
2025-04-10 12:04         ` Dominik Csapak via pve-devel
2025-04-10 12:13           ` Gilberto Ferreira via pve-devel
2025-04-10 12:25           ` Gilberto Ferreira via pve-devel
2025-04-08 15:44 ` [pve-devel] [PATCH manager v7 0/3] allow importing vm disk images on the UI Michael Köppl
2025-04-10 12:04 ` Lukas Wagner via pve-devel
     [not found] ` <c7b3dfb5-89aa-4f42-927d-08475d17e7f0@proxmox.com>
2025-04-10 12:06   ` Dominik Csapak via pve-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=22a457f5-12ce-48f3-9dfa-d4ae90715670@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=t.lamprecht@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal