From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH widget-toolkit] panel/JournalView: fix flickering in journal livemode
Date: Tue, 22 Jun 2021 14:11:09 +0200 [thread overview]
Message-ID: <227f26df-2026-9229-f7fb-eaf3e346fa71@proxmox.com> (raw)
In-Reply-To: <20210622095725.27282-1-d.csapak@proxmox.com>
On 22.06.21 11:57, Dominik Csapak wrote:
> it seems that something changed in extjs 7 which does not quite
> restore the correct scroll position when the identical content is set
> on a component. this means that sometimes, we update the text
> with the identical one, but the scroll position is now off, only
> to scroll back to the bottom
>
> this causes a flickering everytime we do the api call.
>
> instead, only update the component when the content really changed.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> src/panel/JournalView.js | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2021-06-22 12:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 9:57 [pve-devel] " Dominik Csapak
2021-06-22 12:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=227f26df-2026-9229-f7fb-eaf3e346fa71@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox