public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with icons
@ 2023-01-23 13:17 Lukas Wagner
  2023-01-23 13:17 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Lukas Wagner
  2023-01-23 13:17 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Lukas Wagner
  0 siblings, 2 replies; 7+ messages in thread
From: Lukas Wagner @ 2023-01-23 13:17 UTC (permalink / raw)
  To: pve-devel

In our UI, we've been a bit inconsistent with the use of checkboxes/text
for `enabled` properties in table views. Looking through the UI, I've
found that the following UI elements use a checkbox UI control to
indicate wheter something is enabled or not:

 * backup job overview
 * APT repository overview
 * replication job overview

While looking sleek, the problem with this is that from a user's
perspective, a checkbox generally implies that it is operable by
clicking on it (which we allow in other places, to make the matter even
more confusing). Now, for the three UI elements mentioned above, I would 
say it is a good thing that they are not manipulateable from the overview,
in order to avoid any accidental modifications.

In this patch series, the checkbox is replaced by a checkmark
(fa-check) icon if enabled, or by a minus/dash (fa-minus) icon if disabled.

Note: Firewall configuration also uses a checkbox, however there it is
possible to enable/disable elements by clicking on the checkbox. 
As mentioned by Thomas in v1, this could be replaced by a more explicit 
icon-based toggle button in the future series.

proxmox-widget-toolkit:

Lukas Wagner (1):
  repo view: replace non-clickable checkbox with icons

 src/Utils.js                | 6 ++++++
 src/node/APTRepositories.js | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

pve-manager:

Lukas Wagner (1):
  ui: backup: replication: replace non-clickable checkbox with icons

 www/manager6/dc/Backup.js        | 11 ++++++-----
 www/manager6/grid/Replication.js | 11 +++++++----
 2 files changed, 13 insertions(+), 9 deletions(-)


-- 
2.30.2





^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-01-24 15:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-23 13:17 [pve-devel] [PATCH v2 manager/widget-toolkit 0/2] ui: replace non-clickable checkboxes with icons Lukas Wagner
2023-01-23 13:17 ` [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace non-clickable checkbox " Lukas Wagner
2023-01-24 15:24   ` Thomas Lamprecht
2023-01-24 15:30     ` Thomas Lamprecht
2023-01-23 13:17 ` [pve-devel] [PATCH v2 manager] ui: backup: replication: " Lukas Wagner
2023-01-24 15:28   ` Thomas Lamprecht
2023-01-24 15:37     ` Lukas Wagner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal